fix: [release/v0.14.x] Introduce startup probe to CAREN pod to reduce races (#934)

Introduce a more frequent startup probe polling every second, which once
it succeeds will trigger readiness and liveness probes to run at their
default intervals. This reduces chances of races in clusterctl checking
for readiness while keeping the overhead on the kubelet for checking
readiness once the pod is up to a minimum (default probe period).

Author: jimmidyson

charts/cluster-api-runtime-extensions-nutanix/templates/deployment.yaml

@@ -73,7 +73,7 @@ spec:
             fieldRef:
               fieldPath: metadata.namespace
         resources:
-          {{ with .Values.resources }}
+          {{- with .Values.resources }}
           {{- toYaml . | nindent 10 }}
           {{- end }}
         volumeMounts:
@@ -93,9 +93,16 @@ spec:
             port: probes
             scheme: HTTP
             path: /readyz
+        startupProbe:
+          httpGet:
+            port: probes
+            scheme: HTTP
+            path: /healthz
+          periodSeconds: 1
+          failureThreshold: 30
       priorityClassName: {{ .Values.priorityClassName }}
       securityContext:
-        {{ with .Values.securityContext }}
+        {{- with .Values.securityContext }}
         {{- toYaml . | nindent 8}}
         {{- end }}
       volumes: