fix: check HelmReleaseReadyCondition when status is up-to-date

Only checking for HelmReleaseReadyCondition may not be enough,
especially during cluster upgrades where the values in the HCP have changed.

Author: dkoshkin

pkg/handlers/generic/lifecycle/addons/helmaddon.go

@@ -227,7 +227,10 @@ func waitToBeReady(
 			Reader: client,
 			Target: hcp.DeepCopy(),
 			Check: func(_ context.Context, obj *caaphv1.HelmChartProxy) (bool, error) {
-				return conditions.IsTrue(obj, caaphv1.HelmReleaseProxiesReadyCondition), nil
+				if obj.ObjectMeta.Generation != obj.Status.ObservedGeneration {
+					return false, nil
+				}
+				return conditions.IsTrue(obj, caaphv1.HelmReleaseReadyCondition), nil
 			},
 			Interval: 5 * time.Second,
 			Timeout:  30 * time.Second,