REV: Revert casting part of the old changes

Author: seberg

numpy/core/src/multiarray/array_assign_scalar.c

@@ -210,11 +210,8 @@ PyArray_AssignRawScalar(PyArrayObject *dst,
     }
 
     /* Check the casting rule */
-    // TODO: This is incorrect, we need the information if the input was a
-    //       Python scalar?!  Or rather, we want a "inspect" cast-safety
-    //       so to speak.  A special scalar assignment just for this purpose
-    //       _probably_ that should be handled earlier, though!
-    if (!PyArray_CanCastTypeTo(src_dtype, PyArray_DESCR(dst), casting)) {
+    if (!can_cast_scalar_to(src_dtype, src_data,
+            PyArray_DESCR(dst), casting)) {
         npy_set_invalid_cast_error(
                 src_dtype, PyArray_DESCR(dst), casting, NPY_TRUE);
         return -1;

numpy/core/src/multiarray/convert_datatype.h

@@ -47,6 +47,10 @@ PyArray_ValidType(int type);
 NPY_NO_EXPORT int
 dtype_kind_to_ordering(char kind);
 
+NPY_NO_EXPORT npy_bool
+can_cast_scalar_to(PyArray_Descr *scal_type, char *scal_data,
+                   PyArray_Descr *to, NPY_CASTING casting);
+
 /* Used by PyArray_CanCastArrayTo and in the legacy ufunc type resolution */
 NPY_NO_EXPORT npy_bool
 can_cast_pyscalar_scalar_to(