Rewording for gravitational waves caption #245
Conversation
|
@bjnath there's 3 commits in this PR, while you intended to submit only the last one. The reason is that you correctly created a new branch for each change, however you based the new branch off of the branch you submitted the previous PR from. What you want to do instead is base the new branch off of master, so your branches and PRs are independent of each other. Of course if changes depend on earlier commits then that doesn't work, but that's unusual (and not the case here) and you should either keep it in a single PR or comment on the dependency. Don't worry about it for the PR's you already submitted, I'll fix the history for those. For new ones, please try to start from master. If this is a bit confusing please let me know! |
It's dramatic and I struggled with changing it, but the original wording makes NumPy rather than gravitational waves the antecedent of "they".
|
LGTM, merged. Thanks @bjnath |
Argh, on the contrary I know only too well what you mean. I realized this morning that all my PRs would have other PRs coming along for the ride. Sorry for that -- thanks for cleaning it up. I'll revert to master for future ones. |
Brief description of what is fixed or changed
Fixes gh-244