Skip to content

Make "Get started" button link work #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2020
Merged

Make "Get started" button link work #189

merged 1 commit into from
Mar 22, 2020

Conversation

rgommers
Copy link
Member

We have no dedicated "Get started" page. I looked at some other projects, some link to install procedures, some to a quickstart or similar. For now I thought linking to the Learn page is most appropriate. That has the (not so great) quickstart guide in the Sphinx docs, an install link, and a bunch of other resources.

@rgommers rgommers requested a review from joelachance March 22, 2020 15:40
@rgommers rgommers mentioned this pull request Mar 22, 2020
Merged
joelachance
joelachance requested changes Mar 22, 2020
View reviewed changes
Copy link
Collaborator

@joelachance joelachance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the href on the div.

@joelachance joelachance merged commit 467efaf into numpy:master Mar 22, 2020
@rgommers rgommers deleted the getstarted-link branch March 22, 2020 21:52
@InessaPawson
Copy link
Member

@rgommers Makes sense to me. Do you think we need a dedicated "Get Started" page?

@rgommers
Copy link
Member Author

I think a rewrite of the quickstart page (already planned) would be the way to go, rather than a new page.

@shaloo
Copy link
Contributor

shaloo commented Mar 30, 2020 •
edited
Loading

I can take GettingStarted/Quickstart up next once I am done cleaning up 45 and case studies. Is that ok?

@rgommers
Copy link
Member Author

I can take GettingStarted/Quickstart up next once I am done cleaning up 45 and case studies. Is that ok?

@shaloo I think it will be easier to rework https://numpy.org/devdocs/user/quickstart.html after the website is launched, because then it can link back to Install and Learn. What you can do now though is to review it and make an overview of what needs changing. We've recently started doing this (see numpy/numpy#15760 for an example), planning out what should be on a docs page and reviewing that should yield better results than just starting to write.

@shaloo
Copy link
Contributor

shaloo commented Apr 9, 2020 •
edited
Loading

Adding this work-item (#214) to post launch to-do list along with #213

@shaloo shaloo mentioned this pull request Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelachance joelachance joelachance requested changes

Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgommers @InessaPawson @shaloo @joelachance