-
-
Notifications
You must be signed in to change notification settings - Fork 119
Flip the navbar buttons "About us" and "Contribute" #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can I work on this @rgommers?? |
That makes sense I think. There's a lot of discussion on site layout at #43 (comment), but I cannot remember or see a specific comment on order of
You can submit a PR if you want, but I'd like to wait for @InessaPawson's input before merging it. Also note that we have two translations, Brazilian and Japanese. If you swap the order in English, please make sure to also swap the other two languages (should be done in |
Oh ok, sure I will do it for all the languages! |
I don't know that there's a particular convention that puts the "About Us" all the way on the right, at least in the context of our other design choices. Because our header is right-aligned, the last item on the right is where you want to put the "call to action" items, and "Contribute" is the main one for us (why? Corners are easier to hit.). "About Us" is the kind of item I'd want to "bury" in the middle. It's something that people should be able to navigate to at their leisure, but it isn't a call to action. Now, if our header were left-aligned, I'd make the "Contribute" its own button in the top-right corner separate from the other header items, and indeed, "About Us" would be the right-most item from the left-aligned header. |
I appreciate your enthusiasm, @Uttam-Singhh! To echo @rkern, in modern UI/UX design, there is no convention on what buttons should be placed in the top navigation bar and in what order. These choices are determined by objectives and priorities of a project. And as you can tell by reading this thread #43 (comment), we have given a lot of thought to it. I believe the current top menu is optimal to meet the needs of all NumPy stakeholders. |
Oh ok, Thank you @InessaPawson for clearing this out! |
According to convention
"About us"
button always comes at the last of a Navbar.so flip
"About us" button
with"Contribute"
.I'd love to work on this and solve this.
Please give me a green signal and assign me this task.
The text was updated successfully, but these errors were encountered: