Skip to content

Newer Hugo version introduced rendering issue #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rgommers opened this issue Sep 30, 2020 · 3 comments
Closed

Newer Hugo version introduced rendering issue #363

rgommers opened this issue Sep 30, 2020 · 3 comments

Comments

@rgommers
Copy link
Member

rgommers commented Sep 30, 2020

See gh-362: Hugo 0.74.3 worked fine, 0.75.1 broke the navbar. There's two things to do here:

  • Figure out what is broken with the newer Hugo version and fix it.
  • Better control the Hugo versions used for Netlify preview and for deployment, so we will not have unexpected breakage when the Hugo version gets bumped through some Linux package manager system update.

EDIT: for completeness, here is the problematic version (on Arch Linux):

$ hugo version
Hugo Static Site Generator v0.75.1/extended linux/amd64 BuildDate: unknown
@joelachance
Copy link
Collaborator

It appears this was indeed Hugo. I upgraded this morning to Hugo Static Site Generator v0.76.2/extended darwin/amd64 and things are working fine. I'm assuming we download the latest Hugo when we deploy, but can't find it in the repo (it doesn't look like it's in the Makefile). I'm not sure how we deploy, but locking it to a version is probably a good idea.

Hope this is helpful, let me know if I can help more with this, @rgommers

@rgommers
Copy link
Member Author

rgommers commented Oct 8, 2020

Thanks @joelachance, that's helpful!

Deployment is still not automated unfortunately, that's why you can't find it. Issue gh-282 is still open. It's not all that hard, just 1-2 hours of fiddly work.

@rgommers
Copy link
Member Author

This was fixed in Hugo a long time ago; gh-422 is upgrading the Hugo version we use from 0.74.3 to 0.82.0. Either way, this issue is already resolved, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants