Skip to content

Serial commas #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjnath opened this issue May 18, 2020 · 2 comments · Fixed by #277
Closed

Serial commas #237

bjnath opened this issue May 18, 2020 · 2 comments · Fixed by #277
Assignees
Labels

Comments

@bjnath
Copy link
Contributor

bjnath commented May 18, 2020

There's precedent in the NumPy site for use of the serial comma -- that is, a comma before the final 'and' in a list of three things or more:

dev/index.rst:240:
the documentation. Matplotlib, SciPy, and IPython are also required.

dev/conduct/code_of_conduct.rst:37:
2. Be empathetic, welcoming, friendly, and patient. We work together to resolve


The new site does not use it:

./public/index.html:670:
Several of these newer libraries such as CuPy, Sparse and Dask,

./public/index.html:205:
NumPy offers comprehensive mathematical functions, random number generators, linear algebra routines, Fourier transforms and more.

Based on precedent (and the Google guide, if we adopt it), the new site should use serial commas too.

I'd be willing to write the PR.

@bjnath
Copy link
Contributor Author

bjnath commented May 19, 2020

I added serial commas in the Ecosystem edit of PR #242 but haven't checked them sitewide.

@InessaPawson InessaPawson self-assigned this May 20, 2020
@rgommers
Copy link
Member

I've probably been guilty of using this inconsistently. +1 for using it everywhere, and following the Google style guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants