Skip to content

Inconsistency in language selector dropdown visibility #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
InessaPawson opened this issue Feb 20, 2020 · 2 comments · Fixed by #171
Closed

Inconsistency in language selector dropdown visibility #169

InessaPawson opened this issue Feb 20, 2020 · 2 comments · Fixed by #171
Assignees
Labels

Comments

@InessaPawson
Copy link
Member

Some web pages don’t show the language selector dropdown.

@joelachance joelachance self-assigned this Feb 20, 2020
@joelachance
Copy link
Collaborator

This actually is not a bug. The navbar partial checks if there are translations for a given page, and if there aren't any, it won't render the language dropdown (since there's no other language available for that page). The attached PR comments out the Language dropdown until we're in a better place with translations, per @rgommers

@rgommers
Copy link
Member

rgommers commented Mar 8, 2020

Thanks @joelachance, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants