Skip to content

Commit 1111a86

Browse files
authored
Merge pull request #108 from ngoldbaum/nan-comparison-test
fix nan comparison test
2 parents ce8c26b + ea3653a commit 1111a86

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ jobs:
8181
then
8282
rm -r build
8383
fi
84-
meson setup build -Db_sanitize=address,undefined
84+
meson setup build
8585
python -m build --no-isolation --wheel -Cbuilddir=build --config-setting='compile-args=-v' -Csetup-args="-Dbuildtype=debug"
8686
find ./dist/*.whl | xargs python -m pip install
8787
- name: Run stringdtype tests
8888
working-directory: stringdtype
8989
run: |
90-
ASAN_OPTIONS=detect_leaks=false LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so pytest -s -vvv --color=yes
90+
pytest -s -vvv --color=yes
9191
pip uninstall -y pandas
92-
ASAN_OPTIONS=detect_leaks=false LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so pytest -s -vvv --color=yes
92+
pytest -s -vvv --color=yes

quaddtype/tests/test_quaddtype.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,10 @@ def test_unary_ops(op, val, expected):
7272

7373

7474
def test_nan_and_inf():
75-
assert (QuadPrecision("nan") != QuadPrecision("nan")) == (
76-
QuadPrecision("nan") == QuadPrecision("nan"))
75+
# NaN should not equal itself
76+
assert QuadPrecision("nan") != QuadPrecision("nan")
77+
78+
# Test infinity comparisons
7779
assert QuadPrecision("inf") > QuadPrecision("1e1000")
7880
assert QuadPrecision("-inf") < QuadPrecision("-1e1000")
7981

0 commit comments

Comments
 (0)