feat(misc): improve nx cloud setup prompts and messaging (#23218)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit d1c4073)

Author: leosvelperez

packages/create-nx-workspace/src/utils/nx/ab-testing.ts

@@ -15,7 +15,7 @@ const messageOptions = {
         { value: 'skip', name: 'Skip for now' },
       ],
       footer:
-        '\nRead more about remote cache at https://nx.dev/ci/features/remote-cache',
+        '\nWatch a short video on Nx Cloud at https://nx.dev/ci/intro/why-nx-cloud',
       hint: `\n(it's free and can be disabled any time)`,
       fallback: undefined,
     },
@@ -29,7 +29,7 @@ const messageOptions = {
         { value: 'skip', name: 'Skip for now' },
       ],
       footer:
-        '\nRead more about CI benefits with Nx at https://nx.dev/ci/intro/ci-with-nx',
+        '\nWatch a short video on Nx Cloud at https://nx.dev/ci/intro/why-nx-cloud',
       hint: `\n(it's free and can be disabled any time)`,
       fallback: { value: 'skip', key: 'setupNxCloud' },
     },
@@ -97,7 +97,7 @@ export async function recordStat(opts: {
     if (process.env.NX_VERBOSE_LOGGING === 'true') {
       console.log(`Record stat. Major: ${major}`);
     }
-    if (major < 10 || major > 16) return; // test version, skip it
+    if (major < 10 || major > 19) return; // test version, skip it
     const axios = require('axios');
     await (axios['default'] ?? axios)
       .create({

packages/nx/src/command-line/migrate/migrate.ts

@@ -1215,23 +1215,6 @@ async function generateMigrationsJsonAndUpdatePackageJson(
       originalNxJson.installation?.version ??
       readNxVersion(originalPackageJson);
 
-    try {
-      if (
-        ['nx', '@nrwl/workspace'].includes(opts.targetPackage) &&
-        (await isMigratingToNewMajor(from, opts.targetVersion)) &&
-        !isCI() &&
-        !isNxCloudUsed(originalNxJson)
-      ) {
-        await connectToNxCloudWithPrompt('migrate');
-        originalPackageJson = readJsonFile<PackageJson>(
-          join(root, 'package.json')
-        );
-      }
-    } catch {
-      // The above code is to remind folks when updating to a new major and not currently using Nx cloud.
-      // If for some reason it fails, it shouldn't affect the overall migration process
-    }
-
     logger.info(`Fetching meta data about packages.`);
     logger.info(`It may take a few minutes.`);
 
@@ -1269,6 +1252,32 @@ async function generateMigrationsJsonAndUpdatePackageJson(
       ],
     });
 
+    try {
+      if (
+        ['nx', '@nrwl/workspace'].includes(opts.targetPackage) &&
+        (await isMigratingToNewMajor(from, opts.targetVersion)) &&
+        !isCI() &&
+        !isNxCloudUsed(originalNxJson)
+      ) {
+        output.success({
+          title: 'Connect to Nx Cloud',
+          bodyLines: [
+            'Nx Cloud is a first-party CI companion for Nx projects. It improves critical aspects of CI:',
+            '- Speed: 30% - 70% faster CI',
+            '- Cost: 40% - 75% reduction in CI costs',
+            '- Reliability: by automatically identifying flaky tasks and re-running them',
+          ],
+        });
+        await connectToNxCloudWithPrompt('migrate');
+        originalPackageJson = readJsonFile<PackageJson>(
+          join(root, 'package.json')
+        );
+      }
+    } catch {
+      // The above code is to remind folks when updating to a new major and not currently using Nx cloud.
+      // If for some reason it fails, it shouldn't affect the overall migration process
+    }
+
     output.log({
       title: 'Next steps:',
       bodyLines: [

packages/nx/src/utils/ab-testing.ts

@@ -13,7 +13,7 @@ const messageOptions = {
         { value: 'skip', name: 'Skip for now' },
       ],
       footer:
-        '\nRead more about remote cache at https://nx.dev/ci/features/remote-cache',
+        '\nWatch a short video on Nx Cloud at https://nx.dev/ci/intro/why-nx-cloud',
       hint: `\n(it's free and can be disabled any time)`,
     },
   ],
@@ -79,7 +79,7 @@ export async function recordStat(opts: {
     if (process.env.NX_VERBOSE_LOGGING === 'true') {
       console.log(`Record stat. Major: ${major}`);
     }
-    if (major < 10 || major > 16) return; // test version, skip it
+    if (major < 10 || major > 19) return; // test version, skip it
     const axios = require('axios');
     await (axios['default'] ?? axios)
       .create({