fix(vite): ensure test target dependency is not duplicated (#30289)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
Every time the vitest generator was run a new duplicate '^build'
dependency was added to the target defaults for the test task.

## Expected Behavior
No duplicate entries added!

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #30288

---------

Co-authored-by: Colum Ferry <[email protected]>

Author: cogwirrel

packages/vite/src/generators/vitest/vitest-generator.ts

@@ -171,7 +171,9 @@ getTestBed().initTestEnvironment(
     nxJson.targetDefaults ??= {};
     nxJson.targetDefaults[testTarget] ??= {};
     nxJson.targetDefaults[testTarget].dependsOn ??= [];
-    nxJson.targetDefaults[testTarget].dependsOn.push('^build');
+    nxJson.targetDefaults[testTarget].dependsOn = Array.from(
+      new Set([...nxJson.targetDefaults[testTarget].dependsOn, '^build'])
+    );
     updateNxJson(tree, nxJson);
   }
 

packages/vite/src/generators/vitest/vitest.spec.ts

@@ -246,6 +246,24 @@ describe('vitest generator', () => {
   });
 
   describe('TS solution setup', () => {
+    const addProject = (name: string) => {
+      addProjectConfiguration(appTree, name, {
+        root: `packages/${name}`,
+        sourceRoot: `packages/${name}/src`,
+        targets: {
+          lint: {
+            executor: '@nx/eslint:lint',
+            options: {},
+          },
+        },
+      });
+      writeJson(appTree, `packages/${name}/tsconfig.json`, {
+        files: [],
+        include: [],
+        references: [],
+      });
+    };
+
     beforeEach(() => {
       appTree = createTreeWithEmptyWorkspace();
       updateJson(appTree, 'package.json', (json) => {
@@ -261,21 +279,7 @@ describe('vitest generator', () => {
         references: [],
       });
 
-      addProjectConfiguration(appTree, 'pkg1', {
-        root: 'packages/pkg1',
-        sourceRoot: 'packages/pkg1/src',
-        targets: {
-          lint: {
-            executor: '@nx/eslint:lint',
-            options: {},
-          },
-        },
-      });
-      writeJson(appTree, 'packages/pkg1/tsconfig.json', {
-        files: [],
-        include: [],
-        references: [],
-      });
+      addProject('pkg1');
     });
 
     it('should add a tsconfig.spec.json file', async () => {
@@ -331,6 +335,21 @@ describe('vitest generator', () => {
       const nxJson = readNxJson(appTree);
       expect(nxJson.targetDefaults.test.dependsOn).toStrictEqual(['^build']);
     });
+
+    it(`should not duplicate the test target dependency on the deps' build target`, async () => {
+      await generator(appTree, {
+        project: 'pkg1',
+        coverageProvider: 'v8',
+      });
+      addProject('pkg2');
+      await generator(appTree, {
+        project: 'pkg2',
+        coverageProvider: 'v8',
+      });
+
+      const nxJson = readNxJson(appTree);
+      expect(nxJson.targetDefaults.test.dependsOn).toStrictEqual(['^build']);
+    });
   });
 });