Skip to content

Commit 95a1c09

Browse files
thdkFrozenPandaz
thdk
authored and
FrozenPandaz
committed
fix(release): remove duplicate space character in changelog thank you header (#28664)
(cherry picked from commit a0d760f)
1 parent 7a92592 commit 95a1c09

File tree

6 files changed

+46
-46
lines changed

6 files changed

+46
-46
lines changed

‎docs/blog/2024-02-09-versioning-and-releasing-packages.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ It also generates a nice `CHANGELOG.md` for us:
188188

189189
- **buttons:** add new background shadow
190190

191-
### ❤️ Thank You
191+
### ❤️ Thank You
192192

193193
- Juri
194194

‎e2e/release/src/release.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ describe('nx release', () => {
133133
+
134134
+ - an awesome new feature ([{COMMIT_SHA}](https://github.com/nrwl/fake-repo/commit/{COMMIT_SHA}))
135135
+
136-
+ ### ❤️ Thank You
136+
+ ### ❤️ Thank You
137137
+
138138
+ - Test @{COMMIT_AUTHOR}
139139
@@ -153,7 +153,7 @@ describe('nx release', () => {
153153
154154
- an awesome new feature ([{COMMIT_SHA}](https://github.com/nrwl/fake-repo/commit/{COMMIT_SHA}))
155155
156-
### ❤️ Thank You
156+
### ❤️ Thank You
157157
158158
- Test @{COMMIT_AUTHOR}
159159
`);

‎e2e/release/src/version-plans.test.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ Here is another line in the message.
178178
+
179179
+ - Update the fixed packages with a minor release.
180180
+
181-
+ ### ❤️ Thank You
181+
+ ### ❤️ Thank You
182182
+
183183
+ - Test`
184184
);
@@ -192,7 +192,7 @@ Here is another line in the message.
192192
+
193193
+ - Update the fixed packages with a minor release.
194194
+
195-
+ ### ❤️ Thank You
195+
+ ### ❤️ Thank You
196196
+
197197
+ - Test`
198198
);
@@ -208,7 +208,7 @@ Here is another line in the message.
208208
+
209209
+ Here is another line in the message.
210210
+
211-
+ ### ❤️ Thank You
211+
+ ### ❤️ Thank You
212212
+
213213
+ - Test`
214214
);
@@ -225,7 +225,7 @@ Here is another line in the message.
225225
+
226226
+ Here is another line in the message.
227227
+
228-
+ ### ❤️ Thank You
228+
+ ### ❤️ Thank You
229229
+
230230
+ - Test`
231231
);
@@ -242,7 +242,7 @@ Here is another line in the message.
242242
+
243243
+ Here is another line in the message.
244244
+
245-
+ ### ❤️ Thank You
245+
+ ### ❤️ Thank You
246246
+
247247
+ - Test`
248248
);
@@ -321,7 +321,7 @@ Update packages in both groups with a mix #2
321321
+
322322
+ - Update packages in both groups with a mix #2
323323
+
324-
+ ### ❤️ Thank You
324+
+ ### ❤️ Thank You
325325
+
326326
+ - Test`
327327
);
@@ -336,7 +336,7 @@ Update packages in both groups with a mix #2
336336
+
337337
+ - Update packages in both groups with a mix #2
338338
+
339-
+ ### ❤️ Thank You
339+
+ ### ❤️ Thank You
340340
+
341341
+ - Test
342342
`
@@ -352,7 +352,7 @@ Update packages in both groups with a mix #2
352352
+
353353
+ - Update packages in both groups with a mix #1
354354
+
355-
+ ### ❤️ Thank You
355+
+ ### ❤️ Thank You
356356
+
357357
+ - Test`
358358
);
@@ -368,7 +368,7 @@ Update packages in both groups with a mix #2
368368
+
369369
+ - Update packages in both groups with a mix #2
370370
+
371-
+ ### ❤️ Thank You
371+
+ ### ❤️ Thank You
372372
+
373373
+ - Test`
374374
);
@@ -384,7 +384,7 @@ Update packages in both groups with a mix #2
384384
+
385385
+ - Update packages in both groups with a mix #2
386386
+
387-
+ ### ❤️ Thank You
387+
+ ### ❤️ Thank You
388388
+
389389
+ - Test`
390390
);
@@ -549,7 +549,7 @@ const yargs = require('yargs');
549549
+
550550
+ - Update the fixed packages with a minor release.
551551
+
552-
+ ### ❤️ Thank You
552+
+ ### ❤️ Thank You
553553
+
554554
+ - Test`
555555
);
@@ -563,7 +563,7 @@ const yargs = require('yargs');
563563
+
564564
+ - Update the fixed packages with a minor release.
565565
+
566-
+ ### ❤️ Thank You
566+
+ ### ❤️ Thank You
567567
+
568568
+ - Test`
569569
);
@@ -577,7 +577,7 @@ const yargs = require('yargs');
577577
+
578578
+ - Update the independent packages with a patch, preminor, and prerelease.
579579
+
580-
+ ### ❤️ Thank You
580+
+ ### ❤️ Thank You
581581
+
582582
+ - Test`
583583
);
@@ -592,7 +592,7 @@ const yargs = require('yargs');
592592
+
593593
+ - Update the independent packages with a patch, preminor, and prerelease.
594594
+
595-
+ ### ❤️ Thank You
595+
+ ### ❤️ Thank You
596596
+
597597
+ - Test`
598598
);
@@ -607,7 +607,7 @@ const yargs = require('yargs');
607607
+
608608
+ - Update the independent packages with a patch, preminor, and prerelease.
609609
+
610-
+ ### ❤️ Thank You
610+
+ ### ❤️ Thank You
611611
+
612612
+ - Test`
613613
);
@@ -689,7 +689,7 @@ Update packages in both groups with a mix #2
689689
+
690690
+ - Update packages in both groups with a mix #2
691691
+
692-
+ ### ❤️ Thank You
692+
+ ### ❤️ Thank You
693693
+
694694
+ - Test`
695695
);
@@ -704,7 +704,7 @@ Update packages in both groups with a mix #2
704704
+
705705
+ - Update packages in both groups with a mix #2
706706
+
707-
+ ### ❤️ Thank You
707+
+ ### ❤️ Thank You
708708
+
709709
+ - Test
710710
`
@@ -720,7 +720,7 @@ Update packages in both groups with a mix #2
720720
+
721721
+ - Update packages in both groups with a mix #1
722722
+
723-
+ ### ❤️ Thank You
723+
+ ### ❤️ Thank You
724724
+
725725
+ - Test`
726726
);
@@ -736,7 +736,7 @@ Update packages in both groups with a mix #2
736736
+
737737
+ - Update packages in both groups with a mix #2
738738
+
739-
+ ### ❤️ Thank You
739+
+ ### ❤️ Thank You
740740
+
741741
+ - Test`
742742
);
@@ -752,7 +752,7 @@ Update packages in both groups with a mix #2
752752
+
753753
+ - Update packages in both groups with a mix #2
754754
+
755-
+ ### ❤️ Thank You
755+
+ ### ❤️ Thank You
756756
+
757757
+ - Test`
758758
);

‎packages/nx/release/changelog-renderer/index.spec.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ describe('ChangelogRenderer', () => {
168168
- all packages fixed
169169
- **pkg-a:** squashing bugs
170170
171-
### ❤️ Thank You
171+
### ❤️ Thank You
172172
173173
- James Henry"
174174
`);
@@ -235,7 +235,7 @@ describe('ChangelogRenderer', () => {
235235
- all packages fixed
236236
- **pkg-a:** squashing bugs
237237
238-
### ❤️ Thank You
238+
### ❤️ Thank You
239239
240240
- James Henry"
241241
`);
@@ -279,7 +279,7 @@ describe('ChangelogRenderer', () => {
279279
280280
- all packages fixed
281281
282-
### ❤️ Thank You
282+
### ❤️ Thank You
283283
284284
- James Henry"
285285
`);
@@ -427,7 +427,7 @@ describe('ChangelogRenderer', () => {
427427
- all packages fixed
428428
- **pkg-a:** squashing bugs
429429
430-
### ❤️ Thank You
430+
### ❤️ Thank You
431431
432432
- Author 1
433433
- Author 3
@@ -451,7 +451,7 @@ describe('ChangelogRenderer', () => {
451451
452452
- all packages fixed
453453
454-
### ❤️ Thank You
454+
### ❤️ Thank You
455455
456456
- Author 1
457457
- Author 2
@@ -575,7 +575,7 @@ describe('ChangelogRenderer', () => {
575575
576576
- **release:** Revert "fix(release): do not update dependents when they already use "*" (#20607)"
577577
578-
### ❤️ Thank You
578+
### ❤️ Thank You
579579
580580
- James Henry"
581581
`);
@@ -699,7 +699,7 @@ describe('ChangelogRenderer', () => {
699699
700700
- ⚠️ **WebSocketSubject:** no longer extends \`Subject\`.
701701
702-
### ❤️ Thank You
702+
### ❤️ Thank You
703703
704704
- James Henry"
705705
`);
@@ -752,7 +752,7 @@ describe('ChangelogRenderer', () => {
752752
753753
- **WebSocketSubject:** \`WebSocketSubject\` is no longer \`instanceof Subject\`. Check for \`instanceof WebSocketSubject\` instead.
754754
755-
### ❤️ Thank You
755+
### ❤️ Thank You
756756
757757
- James Henry"
758758
`);
@@ -795,7 +795,7 @@ describe('ChangelogRenderer', () => {
795795
796796
- Updated pkg-b to 2.0.0
797797
798-
### ❤️ Thank You
798+
### ❤️ Thank You
799799
800800
- James Henry"
801801
`);
@@ -867,7 +867,7 @@ describe('ChangelogRenderer', () => {
867867
- all packages fixed
868868
- **pkg-a:** squashing bugs
869869
870-
### ❤️ Thank You
870+
### ❤️ Thank You
871871
872872
- James Henry"
873873
`);

‎packages/nx/release/changelog-renderer/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ export default class DefaultChangelogRenderer {
403403
if (authors.length > 0) {
404404
markdownLines.push(
405405
'',
406-
'### ' + '❤️ Thank You',
406+
'### ' + '❤️ Thank You',
407407
'',
408408
...authors
409409
.sort((a, b) => a.name.localeCompare(b.name))

0 commit comments

Comments
 (0)