Skip to content

Commit 942f6fc

Browse files
authored
fix(js): throw an error when generating a publishable lib with --bundler=none (#28221)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Generating a JS publishable library with `--bundler=none` results in the generator silently switching the `bundler` to `tsc` and generating a `build` target. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Trying to generate a JS publishable library with `--bundler=none` should throw an error. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> <!-- Fixes NXC-1075 --> Fixes #
1 parent b82ca22 commit 942f6fc

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

packages/js/src/generators/library/library.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,9 @@ async function normalizeOptions(
856856
}
857857

858858
if (options.bundler === 'none') {
859-
options.bundler = 'tsc';
859+
throw new Error(
860+
`Publishable libraries can't be generated with "--bundler=none". Please select a valid bundler.`
861+
);
860862
}
861863
}
862864

packages/nest/src/generators/library/lib/normalize-options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export function toJsLibraryGeneratorOptions(
6464
): JsLibraryGeneratorSchema {
6565
return {
6666
name: options.name,
67-
bundler: options?.buildable ? 'tsc' : 'none',
67+
bundler: options.buildable || options.publishable ? 'tsc' : 'none',
6868
directory: options.directory,
6969
importPath: options.importPath,
7070
linter: options.linter,

packages/node/src/generators/library/library.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export async function libraryGeneratorInternal(tree: Tree, schema: Schema) {
5959

6060
const libraryInstall = await jsLibraryGenerator(tree, {
6161
...options,
62-
bundler: schema.buildable ? 'tsc' : 'none',
62+
bundler: schema.buildable || schema.publishable ? 'tsc' : 'none',
6363
includeBabelRc: schema.babelJest,
6464
importPath: options.importPath,
6565
testEnvironment: 'node',

0 commit comments

Comments
 (0)