File tree Expand file tree Collapse file tree 4 files changed +19
-12
lines changed
packages/nx/src/utils/lock-file Expand file tree Collapse file tree 4 files changed +19
-12
lines changed Original file line number Diff line number Diff line change @@ -378,7 +378,7 @@ export function transitiveDependencyNpmLookup(
378
378
parentPackage : string ,
379
379
versions : PackageVersions ,
380
380
version : string
381
- ) : string {
381
+ ) : PackageDependency {
382
382
const nestedVersion = Object . values ( versions ) . find ( ( v ) =>
383
383
v . packageMeta . some (
384
384
( p ) =>
@@ -387,11 +387,11 @@ export function transitiveDependencyNpmLookup(
387
387
) ;
388
388
389
389
if ( nestedVersion ) {
390
- return nestedVersion . version ;
390
+ return nestedVersion ;
391
391
}
392
392
393
393
// otherwise search for the matching version
394
- return Object . values ( versions ) . find ( ( v ) => v . rootVersion ) ?. version ;
394
+ return Object . values ( versions ) . find ( ( v ) => v . rootVersion ) ;
395
395
}
396
396
397
397
/**
Original file line number Diff line number Diff line change @@ -281,10 +281,9 @@ export function transitiveDependencyPnpmLookup(
281
281
parentPackage : string ,
282
282
versions : PackageVersions ,
283
283
version : string
284
- ) : string {
284
+ ) : PackageDependency {
285
285
// pnpm's dependencies always point to the exact version so this block is only for insurrance
286
- return Object . values ( versions ) . find ( ( v ) => satisfies ( v . version , version ) )
287
- ?. version ;
286
+ return Object . values ( versions ) . find ( ( v ) => satisfies ( v . version , version ) ) ;
288
287
}
289
288
290
289
/**
Original file line number Diff line number Diff line change 1
1
import { satisfies } from 'semver' ;
2
2
import { defaultHashing } from '../../hasher/hashing-impl' ;
3
- import { LockFileData , PackageVersions } from './lock-file-type' ;
3
+ import {
4
+ LockFileData ,
5
+ PackageDependency ,
6
+ PackageVersions ,
7
+ } from './lock-file-type' ;
4
8
import { workspaceRoot } from '../workspace-root' ;
5
9
import { existsSync , readFileSync } from 'fs' ;
6
10
import {
@@ -84,7 +88,7 @@ type TransitiveLookupFunction = (
84
88
parentPackage : string ,
85
89
versions : PackageVersions ,
86
90
version : string
87
- ) => string ;
91
+ ) => PackageDependency ;
88
92
89
93
export function mapExternalNodes (
90
94
lockFileData : LockFileData ,
@@ -182,7 +186,7 @@ function mapTransitiveDependencies(
182
186
parentPackage ,
183
187
packages [ packageName ] ,
184
188
cleanVersion
185
- ) ;
189
+ ) ?. version ;
186
190
// for some peer dependencies, we won't find installed version so we'll just ignore these
187
191
if ( version ) {
188
192
const nodeName = getNodeName (
Original file line number Diff line number Diff line change @@ -160,10 +160,14 @@ export function transitiveDependencyYarnLookup(
160
160
parentPackage : string ,
161
161
versions : PackageVersions ,
162
162
version : string
163
- ) : string {
163
+ ) : PackageDependency {
164
164
return Object . values ( versions ) . find ( ( v ) =>
165
- v . packageMeta . some ( ( p ) => p === `${ packageName } @${ version } ` )
166
- ) ?. version ;
165
+ v . packageMeta . some (
166
+ ( p ) =>
167
+ p === `${ packageName } @${ version } ` ||
168
+ p === `${ packageName } @npm:${ version } `
169
+ )
170
+ ) ;
167
171
}
168
172
169
173
/**
You can’t perform that action at this time.
0 commit comments