Skip to content

Commit 73858a0

Browse files
authored
fix(vue): bump vue-tsc version to 2.x.x (#26867)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Building a newly created Nuxt workspace/application fails with: ```bash Nuxt Build Error: Cannot find module '@volar/typescript/lib/node/proxyCreateProgram' ``` This can be seen in current CI runs like the following: https://staging.nx.app/runs/bszKddEenc/task/e2e-nuxt%3Ae2e-ci--src%2Fnuxt.test.ts. This is happening because the `vite-plugin-checker` (used by Nuxt) requires `vue-tsc@>=2.0.0`, but the `@nx/vue` plugin installs `vue-tsc@^1.8.8`. ```bash └─┬ nuxt 3.12.3 └─┬ @nuxt/vite-builder 3.12.3 └─┬ vite-plugin-checker 0.7.1 └── ✕ unmet peer vue-tsc@>=2.0.0: found 1.8.27 ``` ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Newly created Nuxt workspaces/applications should build successfully. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
1 parent 92e09d9 commit 73858a0

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

packages/vue/migrations.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
{
22
"generators": {},
33
"packageJsonUpdates": {
4+
"19.4.3": {
5+
"version": "19.4.3-beta.0",
6+
"packages": {
7+
"vue-tsc": {
8+
"version": "^2.0.0",
9+
"alwaysAddToPackageJson": false
10+
}
11+
}
12+
},
413
"17.2.0": {
514
"version": "17.2.0-beta.2",
615
"packages": {

packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ exports[`lib should add vue, vite and vitest to package.json 1`] = `
193193
"typescript": "~5.4.2",
194194
"vite": "^5.0.0",
195195
"vitest": "^1.3.1",
196-
"vue-tsc": "^1.8.8",
196+
"vue-tsc": "^2.0.0",
197197
},
198198
"name": "@proj/source",
199199
}

packages/vue/src/utils/versions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ export const nxVersion = require('../../package.json').version;
22

33
// vue core
44
export const vueVersion = '^3.3.4';
5-
export const vueTscVersion = '^1.8.8';
5+
export const vueTscVersion = '^2.0.0';
66
export const vueRouterVersion = '^4.2.4';
77

88
// test deps

0 commit comments

Comments
 (0)