Skip to content

Commit 6770636

Browse files
authored
fix(angular): directory type is not optional (#30354)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The `directory` option for the ngrx feature store generator is currently marked as optional. With that, if you try to run the generator and do not pass a directory, it will throw an error. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `directory` needs to be a required option. The Nx Console already handles this by pre-populating the option, this just adjusts things appropriately for those not using the console, or calling the generator programatically. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
1 parent 598f4bc commit 6770636

File tree

1 file changed

+1
-1
lines changed
  • packages/angular/src/generators/ngrx-feature-store

1 file changed

+1
-1
lines changed

packages/angular/src/generators/ngrx-feature-store/schema.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ export interface Schema {
22
name: string;
33
minimal: boolean;
44
parent: string;
5-
directory?: string;
5+
directory: string;
66
route?: string;
77
barrels?: boolean;
88
facade?: boolean;

0 commit comments

Comments
 (0)