Skip to content

Commit 63e0f27

Browse files
authored
fix(react): host generator should pass normalized name to remote generator (#28295)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
1 parent c6bb33a commit 63e0f27

File tree

1 file changed

+2
-1
lines changed
  • packages/react/src/generators/host

1 file changed

+2
-1
lines changed

packages/react/src/generators/host/host.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ export async function hostGenerator(
6262
await ensureProjectName(host, options, 'application');
6363
const initTask = await applicationGenerator(host, {
6464
...options,
65+
directory: options.appProjectRoot,
6566
name: options.projectName,
6667
// The target use-case is loading remotes as child routes, thus always enable routing.
6768
routing: true,
@@ -90,7 +91,7 @@ export async function hostGenerator(
9091
typescriptConfiguration: options.typescriptConfiguration,
9192
js: options.js,
9293
dynamic: options.dynamic,
93-
host: options.name,
94+
host: options.projectName,
9495
skipPackageJson: options.skipPackageJson,
9596
bundler: options.bundler,
9697
});

0 commit comments

Comments
 (0)