Skip to content

Commit 5429ba4

Browse files
authored
chore(remix): e2e tests should use strings to prevent issues running commands on windows (#22820)
1 parent f48b305 commit 5429ba4

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

e2e/remix/tests/nx-remix.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,12 @@ describe('Remix E2E Tests', () => {
118118
it('should check for un-escaped dollar signs in routes', async () => {
119119
await expect(async () =>
120120
runCLI(
121-
`generate @nx/remix:route --project ${plugin} --path my.route.$withParams.tsx`
121+
`generate @nx/remix:route --project ${plugin} --path="my.route.$withParams.tsx"`
122122
)
123123
).rejects.toThrow();
124124

125125
runCLI(
126-
`generate @nx/remix:route --project ${plugin} --path my.route.\\$withParams.tsx`
126+
`generate @nx/remix:route --project ${plugin} --path="my.route.\\$withParams.tsx"`
127127
);
128128

129129
expect(() =>
@@ -133,7 +133,7 @@ describe('Remix E2E Tests', () => {
133133

134134
it('should pass un-escaped dollar signs in routes with skipChecks flag', async () => {
135135
await runCommandAsync(
136-
`someWeirdUseCase=route-segment && yarn nx generate @nx/remix:route --project ${plugin} --path my.route.$someWeirdUseCase.tsx --force`
136+
`someWeirdUseCase=route-segment && yarn nx generate @nx/remix:route --project ${plugin} --path="my.route.$someWeirdUseCase.tsx" --force`
137137
);
138138

139139
expect(() =>
@@ -146,12 +146,12 @@ describe('Remix E2E Tests', () => {
146146
it('should check for un-escaped dollar signs in resource routes', async () => {
147147
await expect(async () =>
148148
runCLI(
149-
`generate @nx/remix:resource-route --project ${plugin} --path my.route.$withParams.ts`
149+
`generate @nx/remix:resource-route --project ${plugin} --path="my.route.$withParams.ts"`
150150
)
151151
).rejects.toThrow();
152152

153153
runCLI(
154-
`generate @nx/remix:resource-route --project ${plugin} --path my.route.\\$withParams.ts`
154+
`generate @nx/remix:resource-route --project ${plugin} --path="my.route.\\$withParams.ts"`
155155
);
156156

157157
expect(() =>
@@ -161,7 +161,7 @@ describe('Remix E2E Tests', () => {
161161

162162
xit('should pass un-escaped dollar signs in resource routes with skipChecks flag', async () => {
163163
await runCommandAsync(
164-
`someWeirdUseCase=route-segment && yarn nx generate @nx/remix:resource-route --project ${plugin} --path my.route.$someWeirdUseCase.ts --force`
164+
`someWeirdUseCase=route-segment && yarn nx generate @nx/remix:resource-route --project ${plugin} --path="my.route.$someWeirdUseCase.ts" --force`
165165
);
166166

167167
expect(() =>

0 commit comments

Comments
 (0)