Skip to content

Commit 538fd8c

Browse files
authored
fix(js): update @swc/cli version to fix vulnerability (#30575)
The `@swc/cli` version we're currently using has a security vulnerability due to dependency on `cross-spawn`. This PR updates it to the version that fixes the vulnerability. Advisory: GHSA-3xgq-45jj-v275 ## Current Behavior Existing and new JS workspaces have a high security warning. ## Expected Behavior No high security warning for new workspaces, and existing ones are updated. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
1 parent 962aa76 commit 538fd8c

File tree

8 files changed

+543
-469
lines changed

8 files changed

+543
-469
lines changed

docs/generated/manifests/nx-api.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2624,6 +2624,16 @@
26242624
}
26252625
},
26262626
"migrations": {
2627+
"/nx-api/js/migrations/20.7.1-beta.0-package-updates": {
2628+
"description": "",
2629+
"file": "generated/packages/js/migrations/20.7.1-beta.0-package-updates.json",
2630+
"hidden": false,
2631+
"name": "20.7.1-beta.0-package-updates",
2632+
"version": "20.7.1-beta.0",
2633+
"originalFilePath": "/packages/js",
2634+
"path": "/nx-api/js/migrations/20.7.1-beta.0-package-updates",
2635+
"type": "migration"
2636+
},
26272637
"/nx-api/js/migrations/20.5.0-package-updates": {
26282638
"description": "",
26292639
"file": "generated/packages/js/migrations/20.5.0-package-updates.json",

docs/generated/packages-metadata.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2606,6 +2606,16 @@
26062606
}
26072607
],
26082608
"migrations": [
2609+
{
2610+
"description": "",
2611+
"file": "generated/packages/js/migrations/20.7.1-beta.0-package-updates.json",
2612+
"hidden": false,
2613+
"name": "20.7.1-beta.0-package-updates",
2614+
"version": "20.7.1-beta.0",
2615+
"originalFilePath": "/packages/js",
2616+
"path": "js/migrations/20.7.1-beta.0-package-updates",
2617+
"type": "migration"
2618+
},
26092619
{
26102620
"description": "",
26112621
"file": "generated/packages/js/migrations/20.5.0-package-updates.json",
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
{
2+
"name": "20.7.1-beta.0-package-updates",
3+
"version": "20.7.1-beta.0",
4+
"packages": {
5+
"@swc/cli": { "version": "~0.6.0", "alwaysAddToPackageJson": false }
6+
},
7+
"aliases": [],
8+
"description": "",
9+
"hidden": false,
10+
"implementation": "",
11+
"path": "/packages/js",
12+
"schema": null,
13+
"type": "migration"
14+
}

e2e/js/src/js-executor-swc.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,7 @@ describe('js:swc executor', () => {
2929
const libPackageJson = readJson(`libs/${lib}/package.json`);
3030
expect(libPackageJson.scripts).toBeUndefined();
3131

32-
expect(runCLI(`build ${lib}`)).toContain(
33-
'Successfully compiled: 2 files with swc'
34-
);
32+
expect(() => runCLI(`build ${lib}`)).not.toThrow();
3533
checkFilesExist(
3634
`dist/libs/${lib}/package.json`,
3735
`dist/libs/${lib}/src/index.js`,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
"@svgr/rollup": "^8.1.0",
122122
"@svgr/webpack": "^8.0.1",
123123
"@swc-node/register": "1.9.1",
124-
"@swc/cli": "0.3.12",
124+
"@swc/cli": "0.6.0",
125125
"@swc/core": "1.5.7",
126126
"@swc/helpers": "0.5.11",
127127
"@swc/jest": "0.2.36",

packages/js/migrations.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,15 @@
146146
"alwaysAddToPackageJson": false
147147
}
148148
}
149+
},
150+
"20.7.1-beta.0": {
151+
"version": "20.7.1-beta.0",
152+
"packages": {
153+
"@swc/cli": {
154+
"version": "~0.6.0",
155+
"alwaysAddToPackageJson": false
156+
}
157+
}
149158
}
150159
}
151160
}

packages/js/src/utils/versions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ export const nxVersion = require('../../package.json').version;
22

33
export const esbuildVersion = '^0.19.2';
44
export const prettierVersion = '^2.6.2';
5-
export const swcCliVersion = '~0.3.12';
5+
export const swcCliVersion = '~0.6.0';
66
export const swcCoreVersion = '~1.5.7';
77
export const swcHelpersVersion = '~0.5.11';
88
export const swcNodeVersion = '~1.9.1';

pnpm-lock.yaml

Lines changed: 497 additions & 464 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)