Skip to content

Commit 471f82c

Browse files
authored
fix(js): remove default port for verdaccio (#26502)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> - remove default port for verdaccio so it can take port from config file ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23007
1 parent 4a5eb23 commit 471f82c

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/generated/packages/js/executors/verdaccio.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
},
2222
"port": {
2323
"type": "number",
24-
"description": "Port of local registry that Verdaccio should listen to",
25-
"default": 4873
24+
"description": "Port of local registry that Verdaccio should listen to"
2625
},
2726
"config": {
2827
"type": "string",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export interface VerdaccioExecutorSchema {
22
location: 'global' | 'user' | 'project' | 'none';
33
storage?: string;
4-
port: number;
4+
port?: number;
55
config?: string;
66
clear?: boolean;
77
}

packages/js/src/executors/verdaccio/schema.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
},
1919
"port": {
2020
"type": "number",
21-
"description": "Port of local registry that Verdaccio should listen to",
22-
"default": 4873
21+
"description": "Port of local registry that Verdaccio should listen to"
2322
},
2423
"config": {
2524
"type": "string",

packages/js/src/executors/verdaccio/verdaccio.impl.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,13 @@ function createVerdaccioOptions(
120120
workspaceRoot: string
121121
) {
122122
const verdaccioArgs: string[] = [];
123-
if (options.port) {
124-
verdaccioArgs.push('--listen', options.port.toString());
125-
}
126123
if (options.config) {
127124
verdaccioArgs.push('--config', join(workspaceRoot, options.config));
125+
} else {
126+
options.port ??= 4873; // set default port if config is not provided
127+
}
128+
if (options.port) {
129+
verdaccioArgs.push('--listen', options.port.toString());
128130
}
129131
return verdaccioArgs;
130132
}

0 commit comments

Comments
 (0)