Skip to content

Commit 04b959d

Browse files
Coly010FrozenPandaz
authored andcommitted
fix(vite): nxViteTsPaths plugin should not run-many for vitest (#26574)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> `nxViteTsPaths` does not check if the mode is test and only filters the `run-many` command based on whether Vite's config.command === serve. Vitest will set `config.command` to serve, even for `test` targets. It does set `mode = test` however. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> When `mode === test`, we do not invoke `nx run-many` ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 4456526)
1 parent 5914863 commit 04b959d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

packages/vite/plugins/nx-tsconfig-paths.plugin.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,11 @@ export function nxViteTsPaths(options: nxViteTsPathsOptions = {}) {
8383
There should at least be a tsconfig.base.json or tsconfig.json in the root of the workspace ${workspaceRoot}`);
8484
}
8585

86-
if (!options.buildLibsFromSource && !global.NX_GRAPH_CREATION) {
86+
if (
87+
!options.buildLibsFromSource &&
88+
!global.NX_GRAPH_CREATION &&
89+
config.mode !== 'test'
90+
) {
8791
const projectGraph = await createProjectGraphAsync({
8892
exitOnError: false,
8993
resetDaemonClient: true,
@@ -123,7 +127,7 @@ There should at least be a tsconfig.base.json or tsconfig.json in the root of th
123127

124128
logIt('first parsed tsconfig: ', parsed);
125129
if (parsed.resultType === 'failed') {
126-
throw new Error(`Failed loading tsonfig at ${foundTsConfigPath}`);
130+
throw new Error(`Failed loading tsconfig at ${foundTsConfigPath}`);
127131
}
128132
tsConfigPathsEsm = parsed;
129133

0 commit comments

Comments
 (0)