BREAKING CHANGE: remove handling of deprecated warning headers (#53)

Author: nlf

check-response.js

@@ -1,7 +1,6 @@
 'use strict'
 
 const errors = require('./errors.js')
-const LRU = require('lru-cache')
 const { Response } = require('minipass-fetch')
 const defaultOpts = require('./default-opts.js')
 
@@ -10,7 +9,6 @@ const checkResponse = async ({ method, uri, res, registry, startTime, auth, opts
   if (res.headers.has('npm-notice') && !res.headers.has('x-local-cache'))
     opts.log.notice('', res.headers.get('npm-notice'))
 
-  checkWarnings(res, registry, opts)
   if (res.status >= 400) {
     logRequest(method, res, startTime, opts)
     if (auth && auth.scopeAuthKey && !auth.token && !auth.auth) {
@@ -60,46 +58,6 @@ function logRequest (method, res, startTime, opts) {
   )
 }
 
-const WARNING_REGEXP = /^\s*(\d{3})\s+(\S+)\s+"(.*)"\s+"([^"]+)"/
-const BAD_HOSTS = new LRU({ max: 50 })
-
-function checkWarnings (res, registry, opts) {
-  if (res.headers.has('warning') && !BAD_HOSTS.has(registry)) {
-    const warnings = {}
-    // note: headers.raw() will preserve case, so we might have a
-    // key on the object like 'WaRnInG' if that was used first
-    for (const [key, value] of Object.entries(res.headers.raw())) {
-      if (key.toLowerCase() !== 'warning')
-        continue
-      value.forEach(w => {
-        const match = w.match(WARNING_REGEXP)
-        if (match) {
-          warnings[match[1]] = {
-            code: match[1],
-            host: match[2],
-            message: match[3],
-            date: new Date(match[4]),
-          }
-        }
-      })
-    }
-    BAD_HOSTS.set(registry, true)
-    if (warnings['199']) {
-      if (warnings['199'].message.match(/ENOTFOUND/))
-        opts.log.warn('registry', `Using stale data from ${registry} because the host is inaccessible -- are you offline?`)
-      else
-        opts.log.warn('registry', `Unexpected warning for ${registry}: ${warnings['199'].message}`)
-    }
-    if (warnings['111']) {
-      // 111 Revalidation failed -- we're using stale data
-      opts.log.warn(
-        'registry',
-        `Using stale data from ${registry} due to a request error during revalidation.`
-      )
-    }
-  }
-}
-
 function checkErrors (method, res, startTime, opts) {
   return res.buffer()
     .catch(() => null)

package-lock.json

@@ -29,7 +29,6 @@
   },
   "license": "ISC",
   "dependencies": {
-    "lru-cache": "^6.0.0",
     "make-fetch-happen": "^8.0.9",
     "minipass": "^3.1.3",
     "minipass-fetch": "^1.3.0",

package.json

@@ -135,30 +135,6 @@ t.test('redact password from log', t => {
   res.body.emit('end')
 })
 
-t.test('bad-formatted warning headers', t => {
-  const headers = new Headers()
-  headers.has = header => header === 'warning' ? 'foo' : undefined
-  headers.raw = () => ({
-    warning: ['100 - foo'],
-  })
-  const res = Object.assign({}, mockFetchRes, {
-    headers,
-  })
-  return t.resolves(checkResponse({
-    method: 'get',
-    res,
-    registry,
-    startTime,
-    opts: {
-      log: Object.assign({}, silentLog, {
-        warn (header, msg) {
-          t.fail('should not log warnings')
-        },
-      }),
-    },
-  }))
-})
-
 t.test('report auth for registry, but not for this request', t => {
   const res = Object.assign({}, mockFetchRes, {
     buffer: () => Promise.resolve(Buffer.from('ok')),

test/check-response.js

@@ -466,24 +466,6 @@ t.test('pickRegistry through opts.spec', t => {
   ))
 })
 
-t.test('log warning header info', t => {
-  tnock(t, defaultOpts.registry)
-    .get('/hello')
-    .reply(200, { hello: 'world' }, { Warning: '199 - "ENOTFOUND" "Wed, 21 Oct 2015 07:28:00 GMT"' })
-  const opts = {
-    ...OPTS,
-    log: Object.assign({}, silentLog, {
-      warn (header, msg) {
-        t.equal(header, 'registry', 'expected warn log header')
-        t.equal(msg, `Using stale data from ${defaultOpts.registry} because the host is inaccessible -- are you offline?`, 'logged out at WARNING level')
-      },
-    }),
-  }
-  t.plan(3)
-  return fetch('/hello', opts)
-    .then(res => t.equal(res.status, 200, 'got successful response'))
-})
-
 t.test('miscellaneous headers', t => {
   tnock(t, defaultOpts.registry)
     .matchHeader('npm-session', session =>