fix(config): remove isFromCI and npm-is-ci

BREAKING CHANGE: config items are being removed

Author: wraithgar

README.md

@@ -309,13 +309,6 @@ previously-generated integrity hash for the saved request information, so
 `EINTEGRITY` errors can happen if [`opts.cache`](#opts-cache) is used, even if
 `opts.integrity` is not passed in.
 
-##### <a name='opts-isFromCI'></a> `opts.isFromCI`
-
-* Type: Boolean
-* Default: Based on environment variables
-
-This is used to populate the `npm-in-ci` request header sent to the registry.
-
 ##### <a name="opts-key"></a> `opts.key`
 
 * Type: String

default-opts.js

@@ -1,7 +1,5 @@
 const pkg = require('./package.json')
-const ciDetect = require('@npmcli/ci-detect')
 module.exports = {
-  isFromCI: ciDetect(),
   log: require('./silentlog.js'),
   maxSockets: 12,
   method: 'GET',

index.js

@@ -177,7 +177,6 @@ function getCacheMode (opts) {
 
 function getHeaders (uri, auth, opts) {
   const headers = Object.assign({
-    'npm-in-ci': !!opts.isFromCI,
     'user-agent': opts.userAgent,
   }, opts.headers || {})
 

package-lock.json

@@ -29,7 +29,6 @@
   },
   "license": "ISC",
   "dependencies": {
-    "@npmcli/ci-detect": "^1.0.0",
     "lru-cache": "^6.0.0",
     "make-fetch-happen": "^8.0.9",
     "minipass": "^3.1.3",

package.json

@@ -19,9 +19,6 @@ const fetch = require('../index.js')
 
 npmlog.level = process.env.LOGLEVEL || 'silent'
 const OPTS = {
-  // just to make sure we hit the second branch when
-  // we are ACTUALLY in CI
-  isFromCI: false,
   log: npmlog,
   timeout: 0,
   retry: {
@@ -487,21 +484,6 @@ t.test('log warning header info', t => {
     .then(res => t.equal(res.status, 200, 'got successful response'))
 })
 
-t.test('npm-in-ci header with forced CI=false', t => {
-  const CI = process.env.CI
-  process.env.CI = false
-  t.teardown(t => {
-    process.env.CI = CI
-  })
-  tnock(t, defaultOpts.registry)
-    .get('/hello')
-    .reply(200, { hello: 'world' })
-  return fetch('/hello', OPTS)
-    .then(res => {
-      t.equal(res.status, 200, 'got successful response')
-    })
-})
-
 t.test('miscellaneous headers', t => {
   tnock(t, defaultOpts.registry)
     .matchHeader('npm-session', session =>
@@ -510,8 +492,6 @@ t.test('miscellaneous headers', t => {
       t.strictSame(scope, ['@foo'], 'scope set from options'))
     .matchHeader('user-agent', ua =>
       t.strictSame(ua, ['agent of use'], 'UA set from options'))
-    .matchHeader('npm-in-ci', ci =>
-      t.strictSame(ci, ['false'], 'CI set from options'))
     .matchHeader('npm-command', cmd =>
       t.strictSame(cmd, ['hello-world'], 'command set from options'))
     .get('/hello')