Skip to content

Commit 0ea0698

Browse files
committed
Getting rid of "master"s and "slave"s in favour of "parent" and "sub-"interfaces in the name of PC :)
1 parent e8b2192 commit 0ea0698

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

Diff for: README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -279,8 +279,8 @@ This way users can dynamically configure various networking solutions via the sa
279279
A generic framework supporting this method is built into DANM's code, but still this level of integration requires case-by-case implementation.
280280
As a result, DANM currently supports two integration levels:
281281

282-
- **Dynamic integration level:** CNI-specific network attributes (such as IP ranges, master host devices etc.) can be controlled on a per network level, taken directly from a DanmNet object
283-
- **Static integration level:** CNI-specific network attributes (such as IP ranges, master host devices etc.) can be only configured on a per node level, via a static CNI configuration files (Note: this is the default CNI configuration method)
282+
- **Dynamic integration level:** CNI-specific network attributes (such as IP ranges, parent host devices etc.) can be controlled on a per network level, taken directly from a DanmNet object
283+
- **Static integration level:** CNI-specific network attributes (such as IP ranges, parent host devices etc.) can be only configured on a per node level, via a static CNI configuration files (Note: this is the default CNI configuration method)
284284

285285
Our aim is to integrate all the popular CNIs into the DANM eco-system over time, but currently the following CNI's achieved dynamic integration level:
286286

@@ -336,8 +336,8 @@ DANM's IPVLAN CNI uses the Linux kernel's IPVLAN module to provision high-speed,
336336
4.9, 4.11, or 4.14 would be even better (lotta bug fixes)*
337337

338338
The CNI provisions IPVLAN interfaces in L2 mode, and supports the following extra features:
339-
* attaching IPVLAN slaves to any host interface
340-
* attaching IPVLAN slaves to dynamically created VLAN or VxLAN host interfaces
339+
* attaching IPVLAN sub-interfaces to any host interface
340+
* attaching IPVLAN sub-interfaces to dynamically created VLAN or VxLAN host interfaces
341341
* renaming the created interfaces according to the "container_prefix" attribute defined in the DanmNet object
342342
* allocating IP addresses by using DANM's flexible, in-built IPAM module
343343
* provisioning generic IP routes into a configured routing table inside the Pod's network namespace

Diff for: schema/DanmNet.yaml

+5-5
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ spec:
1818
NetworkID: ## NETWORK_NAME ##
1919
# This parameter, if present, denotes which backend willl be used to provision the container interfaces connected to this network.
2020
# Currently supported values with dynamic integration level are IPVLAN (default), SRIOV, or MACVLAN.
21-
# - IPVLAN option results in an IPVLAN slave interface provisioned in L2 mode, and connected to the designated host device
21+
# - IPVLAN option results in an IPVLAN sub-interface provisioned in L2 mode, and connected to the designated host device
2222
# - SRIOV option pushes an already existing Virtual Function of the configured host device to the container's netns
23-
# - MACVLAN option results in a MACVLAN slave interface provisioned in bridge mode, and connected to the designated host device
23+
# - MACVLAN option results in a MACVLAN sub-interface provisioned in bridge mode, and connected to the designated host device
2424
# For any other CNI backend DANM will read their configuration from the configured CNI config directory.
2525
# E.g. when a Pod is connected to a DanmNet with "NetworkType" set to "flannel", DANM will pass the content of /etc/cni/net.d/flannel.conf file to the /opt/cni/bin/flannel binary by invoking a standard CNI operation.
2626
# The default IPVLAN backend will be used if this parameter is not specified.
@@ -31,11 +31,11 @@ spec:
3131
# Dynamic configuration is supported only for IPVLAN, and SRIOV backends.
3232
# Other networks are always provisioned from static configuration. Options are silently ignored if NetworkType is set to a non-dynamically integrated backend.
3333
Options:
34-
# Name of the master host device (i.e. physical host NIC).
35-
# Slave interfaces are connected to this NIC in case NetworkType is set to IPVLAN, or MACVLAN.
34+
# Name of the parent host device (i.e. physical host NIC).
35+
# Sub-interfaces are connected to this NIC in case NetworkType is set to IPVLAN, or MACVLAN.
3636
# A Virtual Function belonging to this Physical Function is taken-up in case NetworkType is set to SRIOV.
3737
# OPTIONAL - STRING
38-
host_device: ## MASTER_DEVICE_NAME ##
38+
host_device: ## PARENT_DEVICE_NAME ##
3939
# The IPv4 CIDR notation of the subnet associated with the network.
4040
# Pods connecting to this network will get their IPs from this subnet, if defined.
4141
# Only has an effect with dynamically integrated backends. Ignored for other NetworkTypes.

0 commit comments

Comments
 (0)