Skip to content

Commit ff587de

Browse files
ofrobotsMylesBorins
authored andcommitted
build: disable V8 snapshots
PR-URL: https://github.com/nodejs/node-private/pull/84 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
1 parent 69a8053 commit ff587de

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

configure

+4-4
Original file line numberDiff line numberDiff line change
@@ -419,12 +419,12 @@ parser.add_option('--without-perfctr',
419419
# Dummy option for backwards compatibility
420420
parser.add_option('--with-snapshot',
421421
action='store_true',
422-
dest='unused_with_snapshot',
422+
dest='with_snapshot',
423423
help=optparse.SUPPRESS_HELP)
424424

425425
parser.add_option('--without-snapshot',
426426
action='store_true',
427-
dest='without_snapshot',
427+
dest='unused_without_snapshot',
428428
help=optparse.SUPPRESS_HELP)
429429

430430
parser.add_option('--without-ssl',
@@ -802,7 +802,7 @@ def configure_node(o):
802802
cross_compiling = (options.cross_compiling
803803
if options.cross_compiling is not None
804804
else target_arch != host_arch)
805-
want_snapshots = not options.without_snapshot
805+
want_snapshots = 1 if options.with_snapshot else 0
806806
o['variables']['want_separate_host_toolset'] = int(
807807
cross_compiling and want_snapshots)
808808
o['variables']['want_separate_host_toolset_mkpeephole'] = int(
@@ -948,7 +948,7 @@ def configure_v8(o):
948948
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
949949
o['variables']['v8_optimized_debug'] = 0 # Compile with -O0 in debug builds.
950950
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
951-
o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true'
951+
o['variables']['v8_use_snapshot'] = b(options.with_snapshot)
952952
o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)
953953
o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8)
954954
o['variables']['force_dynamic_crt'] = 1 if options.shared else 0

0 commit comments

Comments
 (0)