Skip to content

Commit fca0da7

Browse files
chasestarritaloacasas
authored andcommitted
test: improve tests in pummel/test-exec
* add asset.strictEqual to stdout and stderr. Fixes no-unused-vars. * replace double quotes with single PR-URL: #10757 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent d64e237 commit fca0da7

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

test/pummel/test-exec.js

+6
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ exec(SLEEP3_COMMAND, { timeout: 50 }, function(err, stdout, stderr) {
6363
assert.ok(err);
6464
assert.ok(err.killed);
6565
assert.strictEqual(err.signal, 'SIGTERM');
66+
assert.strictEqual(stdout, '');
67+
assert.strictEqual(stderr, '');
6668
});
6769

6870

@@ -85,6 +87,8 @@ function killMeTwiceCallback(err, stdout, stderr) {
8587
assert.ok(err);
8688
assert.ok(err.killed);
8789
assert.strictEqual(err.signal, 'SIGTERM');
90+
assert.strictEqual(stdout, '');
91+
assert.strictEqual(stderr, '');
8892

8993
// the timeout should still be in effect
9094
console.log('\'sleep 3\' was already killed. Took %d ms', diff);
@@ -96,6 +100,8 @@ exec('python -c "print 200000*\'C\'"', {maxBuffer: 1000},
96100
function(err, stdout, stderr) {
97101
assert.ok(err);
98102
assert.ok(/maxBuffer/.test(err.message));
103+
assert.strictEqual(stdout, '');
104+
assert.strictEqual(stderr, '');
99105
});
100106

101107

0 commit comments

Comments
 (0)