console,test: make message test more accurate

Make a message test more accurate in what it’s testing for.
This requires not swallowing stack overflow RangeErrors in
`console.log` and similar methods, which I would consider a
bugfix in itself.

PR-URL: #14580
Fixes: nodejs/node-v8#5
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>

Author: addaleax

lib/console.js

@@ -94,6 +94,10 @@ function write(ignoreErrors, stream, string, errorhandler) {
 
     stream.write(string, errorhandler);
   } catch (e) {
+    // console is a debugging utility, so it swallowing errors is not desirable
+    // even in edge cases such as low stack space.
+    if (e.message === 'Maximum call stack size exceeded')
+      throw e;
     // Sorry, there’s no proper way to pass along the error here.
   } finally {
     stream.removeListener('error', noop);

test/message/console_low_stack_space.js

@@ -6,17 +6,26 @@ global.console = {};
 
 require('../common');
 
+// This test checks that, if Node cannot put together the `console` object
+// because it is low on stack space while doing so, it can succeed later
+// once the stack has unwound a little, and `console` is in a usable state then.
+
+let compiledConsole;
+
 function a() {
   try {
     return a();
   } catch (e) {
-    const console = consoleDescriptor.get();
-    if (console.log) {
-      console.log('Hello, World!');
+    compiledConsole = consoleDescriptor.get();
+    if (compiledConsole.log) {
+      // Using `console.log` itself might not succeed yet, but the code for it
+      // has been compiled.
     } else {
       throw e;
     }
   }
 }
 
 a();
+
+compiledConsole.log('Hello, World!');