Skip to content

Commit f6ddbaf

Browse files
refackjasnell
authored andcommitted
test: performance, remove Popen(shell=True) on Win
not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2 PR-URL: #12138 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent e77a83f commit f6ddbaf

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

tools/test.py

-1
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,6 @@ def RunProcess(context, timeout, args, **rest):
617617
pty_out = rest.pop('pty_out')
618618

619619
process = subprocess.Popen(
620-
shell = utils.IsWindows(),
621620
args = popen_args,
622621
**rest
623622
)

0 commit comments

Comments
 (0)