Skip to content

Commit f44b18f

Browse files
committed
cluster: deprecate worker.suicide
Deprecate worker.suicide in favor of worker.exitedAfterDisconnect. PR-URL: #3747 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
1 parent abd0d68 commit f44b18f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

lib/cluster.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const dgram = require('dgram');
66
const fork = require('child_process').fork;
77
const net = require('net');
88
const util = require('util');
9+
const internalUtil = require('internal/util');
910
const SCHED_NONE = 1;
1011
const SCHED_RR = 2;
1112

@@ -30,14 +31,14 @@ function Worker(options) {
3031
this.exitedAfterDisconnect = undefined;
3132

3233
Object.defineProperty(this, 'suicide', {
33-
get: function() {
34-
// TODO: Print deprecation message.
34+
get: internalUtil.deprecate(() => {
3535
return this.exitedAfterDisconnect;
36-
},
37-
set: function(val) {
38-
// TODO: Print deprecation message.
36+
}, 'worker.suicide is deprecated. ' +
37+
'Please use worker.exitedAfterDisconnect.'),
38+
set: internalUtil.deprecate((val) => {
3939
this.exitedAfterDisconnect = val;
40-
},
40+
}, 'worker.suicide is deprecated. ' +
41+
'Please use worker.exitedAfterDisconnect.'),
4142
enumerable: true
4243
});
4344

0 commit comments

Comments
 (0)