Skip to content

Commit f3efaee

Browse files
hiroppyevanlucas
authored andcommitted
test: increase coverage for stream's duplex
Make use of Arrow function. Add a small test and this file's coverage is 100%. https://github.com/nodejs/node/blob/a647d82f83ad5ddad5db7be2cc24c3d686121792/lib/_stream_duplex.js#L25 Coverage: https://coverage.nodejs.org/coverage-067be658f966dafe/root/_stream_duplex.js.html PR-URL: #10963 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent b5e8413 commit f3efaee

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

test/parallel/test-stream-duplex.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -5,27 +5,28 @@ const Duplex = require('stream').Transform;
55

66
const stream = new Duplex({ objectMode: true });
77

8+
assert(Duplex() instanceof Duplex);
89
assert(stream._readableState.objectMode);
910
assert(stream._writableState.objectMode);
1011

1112
let written;
1213
let read;
1314

14-
stream._write = function(obj, _, cb) {
15+
stream._write = (obj, _, cb) => {
1516
written = obj;
1617
cb();
1718
};
1819

19-
stream._read = function() {};
20+
stream._read = () => {};
2021

21-
stream.on('data', function(obj) {
22+
stream.on('data', (obj) => {
2223
read = obj;
2324
});
2425

2526
stream.push({ val: 1 });
2627
stream.end({ val: 2 });
2728

28-
process.on('exit', function() {
29+
process.on('exit', () => {
2930
assert.strictEqual(read.val, 1);
3031
assert.strictEqual(written.val, 2);
3132
});

0 commit comments

Comments
 (0)