Skip to content

Commit ea011eb

Browse files
bradleythughesjasnell
authored andcommitted
build: add -DZLIB_CONST when building with --shared-zlib
Commit 782620f added the define only when building with the bundled zlib. Using a shared zlib results in build breakage: ../src/inspector_agent.cc:179:16: error: assigning to 'Bytef *' (aka 'unsigned char *') from incompatible type 'const uint8_t *' (aka 'const unsigned char *') strm.next_in = PROTOCOL_JSON + 3; ^ ~~~~~~~~~~~~~~~~~ 1 error generated. PR-URL: #9077 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
1 parent ee9062b commit ea011eb

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

node.gyp

+2
Original file line numberDiff line numberDiff line change
@@ -480,6 +480,8 @@
480480
}],
481481
[ 'node_shared_zlib=="false"', {
482482
'dependencies': [ 'deps/zlib/zlib.gyp:zlib' ],
483+
}, {
484+
'defines': [ 'ZLIB_CONST' ],
483485
}],
484486

485487
[ 'node_shared_http_parser=="false"', {

0 commit comments

Comments
 (0)