Skip to content

Commit e8ad773

Browse files
committed
src: remove --noharmony_classes again
Now that V8 has been upgraded, remove the --noharmony_classes and --noharmony_object_literals workarounds from commits a2751e3 and 4e58211. PR-URL: #490 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Kenan Sulayman <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
1 parent 334020e commit e8ad773

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/node.cc

-8
Original file line numberDiff line numberDiff line change
@@ -3337,14 +3337,6 @@ void Init(int* argc,
33373337
DispatchDebugMessagesAsyncCallback);
33383338
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
33393339

3340-
// TODO(bnoordhuis) V8 3.32 is unshipping Harmony classes for the moment.
3341-
// We're currently at 3.31, disable classes for feature parity. Remove
3342-
// again when we upgrade.
3343-
V8::SetFlagsFromString("--noharmony_classes",
3344-
sizeof("--noharmony_classes") - 1);
3345-
V8::SetFlagsFromString("--noharmony_object_literals",
3346-
sizeof("--noharmony_object_literals") - 1);
3347-
33483340
#if defined(NODE_V8_OPTIONS)
33493341
// Should come before the call to V8::SetFlagsFromCommandLine()
33503342
// so the user can disable a flag --foo at run-time by passing

0 commit comments

Comments
 (0)