Skip to content

Commit e7b656d

Browse files
addaleaxitaloacasas
authored andcommitted
Revert "repl: disable Ctrl+C support on win32 for now"
This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: #7837 PR-URL: #8645 Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 6e8d627 commit e7b656d

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

lib/repl.js

+2-9
Original file line numberDiff line numberDiff line change
@@ -322,13 +322,7 @@ function REPLServer(prompt,
322322
if (!err) {
323323
// Unset raw mode during evaluation so that Ctrl+C raises a signal.
324324
let previouslyInRawMode;
325-
326-
// Temporarily disabled on Windows due to output problems that likely
327-
// result from the raw mode switches here, see
328-
// https://github.com/nodejs/node/issues/7837
329-
// Setting NODE_REPL_CTRLC is meant as a temporary opt-in for debugging.
330-
if (self.breakEvalOnSigint &&
331-
(process.platform !== 'win32' || process.env.NODE_REPL_CTRLC)) {
325+
if (self.breakEvalOnSigint) {
332326
// Start the SIGINT watchdog before entering raw mode so that a very
333327
// quick Ctrl+C doesn’t lead to aborting the process completely.
334328
utilBinding.startSigintWatchdog();
@@ -348,8 +342,7 @@ function REPLServer(prompt,
348342
result = script.runInContext(context, scriptOptions);
349343
}
350344
} finally {
351-
if (self.breakEvalOnSigint &&
352-
(process.platform !== 'win32' || process.env.NODE_REPL_CTRLC)) {
345+
if (self.breakEvalOnSigint) {
353346
// Reset terminal mode to its previous value.
354347
self._setRawMode(previouslyInRawMode);
355348

0 commit comments

Comments
 (0)