Skip to content

Commit e350deb

Browse files
committed
doc: edit pull request template
Move checklist instructions closer to the checklist. Trim unnecessary words. PR-URL: #7058 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent 85da963 commit e350deb

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
<!--
2-
Thank you for your pull request. Please review below requirements and walk
3-
through the checklist. You can 'tick' a box by using the letter "x": [x].
2+
Thank you for your pull request. Please review below requirements.
43
5-
Run the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on
6-
Windows.
4+
Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.
75
86
If this aims to fix a regression or you’re adding a feature, make sure you also
97
write a test. If possible, include a benchmark that quantifies your changes.
@@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
1311
-->
1412

1513
##### Checklist
16-
<!-- remove lines that do not apply to you -->
14+
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
1715

1816
- [ ] tests and code linting passes
1917
- [ ] a test and/or benchmark is included

0 commit comments

Comments
 (0)