Skip to content

Commit de4161d

Browse files
committed
src: remove unused internals from node.cc
Remove a couple of internal methods that are neither exported in the public headers nor used internally anywhere. PR-URL: #7117 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent e7f1c00 commit de4161d

File tree

2 files changed

+0
-75
lines changed

2 files changed

+0
-75
lines changed

src/node.cc

-53
Original file line numberDiff line numberDiff line change
@@ -722,47 +722,6 @@ const char *signo_string(int signo) {
722722
}
723723

724724

725-
// Convenience methods
726-
727-
728-
void ThrowError(v8::Isolate* isolate, const char* errmsg) {
729-
Environment::GetCurrent(isolate)->ThrowError(errmsg);
730-
}
731-
732-
733-
void ThrowTypeError(v8::Isolate* isolate, const char* errmsg) {
734-
Environment::GetCurrent(isolate)->ThrowTypeError(errmsg);
735-
}
736-
737-
738-
void ThrowRangeError(v8::Isolate* isolate, const char* errmsg) {
739-
Environment::GetCurrent(isolate)->ThrowRangeError(errmsg);
740-
}
741-
742-
743-
void ThrowErrnoException(v8::Isolate* isolate,
744-
int errorno,
745-
const char* syscall,
746-
const char* message,
747-
const char* path) {
748-
Environment::GetCurrent(isolate)->ThrowErrnoException(errorno,
749-
syscall,
750-
message,
751-
path);
752-
}
753-
754-
755-
void ThrowUVException(v8::Isolate* isolate,
756-
int errorno,
757-
const char* syscall,
758-
const char* message,
759-
const char* path,
760-
const char* dest) {
761-
Environment::GetCurrent(isolate)
762-
->ThrowUVException(errorno, syscall, message, path, dest);
763-
}
764-
765-
766725
Local<Value> ErrnoException(Isolate* isolate,
767726
int errorno,
768727
const char *syscall,
@@ -1269,18 +1228,6 @@ Local<Value> MakeCallback(Environment* env,
12691228
}
12701229

12711230

1272-
// Internal only.
1273-
Local<Value> MakeCallback(Environment* env,
1274-
Local<Object> recv,
1275-
uint32_t index,
1276-
int argc,
1277-
Local<Value> argv[]) {
1278-
Local<Value> cb_v = recv->Get(index);
1279-
CHECK(cb_v->IsFunction());
1280-
return MakeCallback(env, recv.As<Value>(), cb_v.As<Function>(), argc, argv);
1281-
}
1282-
1283-
12841231
Local<Value> MakeCallback(Environment* env,
12851232
Local<Object> recv,
12861233
Local<String> symbol,

src/node_internals.h

-22
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,6 @@ v8::Local<v8::Value> MakeCallback(Environment* env,
5555
int argc = 0,
5656
v8::Local<v8::Value>* argv = nullptr);
5757

58-
// Call with valid HandleScope and while inside Context scope.
59-
v8::Local<v8::Value> MakeCallback(Environment* env,
60-
v8::Local<v8::Object> recv,
61-
uint32_t index,
62-
int argc = 0,
63-
v8::Local<v8::Value>* argv = nullptr);
64-
6558
// Call with valid HandleScope and while inside Context scope.
6659
v8::Local<v8::Value> MakeCallback(Environment* env,
6760
v8::Local<v8::Object> recv,
@@ -193,21 +186,6 @@ inline MUST_USE_RESULT bool ParseArrayIndex(v8::Local<v8::Value> arg,
193186
return true;
194187
}
195188

196-
void ThrowError(v8::Isolate* isolate, const char* errmsg);
197-
void ThrowTypeError(v8::Isolate* isolate, const char* errmsg);
198-
void ThrowRangeError(v8::Isolate* isolate, const char* errmsg);
199-
void ThrowErrnoException(v8::Isolate* isolate,
200-
int errorno,
201-
const char* syscall = nullptr,
202-
const char* message = nullptr,
203-
const char* path = nullptr);
204-
void ThrowUVException(v8::Isolate* isolate,
205-
int errorno,
206-
const char* syscall = nullptr,
207-
const char* message = nullptr,
208-
const char* path = nullptr,
209-
const char* dest = nullptr);
210-
211189
class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
212190
public:
213191
inline uint32_t* zero_fill_field() { return &zero_fill_field_; }

0 commit comments

Comments
 (0)