Skip to content

Commit dd9aefd

Browse files
cjihrigitaloacasas
authored andcommitted
test: use const for all require() calls
PR-URL: #10550 Reviewed-By: Rich Trott <[email protected]>
1 parent 5250b33 commit dd9aefd

File tree

603 files changed

+1567
-1546
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

603 files changed

+1567
-1546
lines changed

test/addons/async-hello-world/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
const common = require('../../common');
3-
var assert = require('assert');
3+
const assert = require('assert');
44
const binding = require(`./build/${common.buildType}/binding`);
55

66
binding(5, common.mustCall(function(err, val) {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
const common = require('../../common');
3-
var assert = require('assert');
3+
const assert = require('assert');
44
const binding = require(`./build/${common.buildType}/binding`);
55
assert.strictEqual(binding(), 'world');
66
console.log('binding.hello() =', binding());

test/addons/hello-world/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
const common = require('../../common');
3-
var assert = require('assert');
3+
const assert = require('assert');
44
const binding = require(`./build/${common.buildType}/binding`);
55
assert.strictEqual(binding.hello(), 'world');
66
console.log('binding.hello() =', binding.hello());

test/addons/load-long-path/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ var contents = fs.readFileSync(addonPath);
3232
fs.writeFileSync(addonDestinationPath, contents);
3333

3434
// Attempt to load at long path destination
35-
var addon = require(addonDestinationPath);
35+
const addon = require(addonDestinationPath);
3636
assert.notEqual(addon, null);
3737
assert.strictEqual(addon.hello(), 'world');

test/addons/repl-domain-abort/test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
'use strict';
2-
var common = require('../../common');
3-
var assert = require('assert');
4-
var repl = require('repl');
5-
var stream = require('stream');
6-
var path = require('path');
2+
const common = require('../../common');
3+
const assert = require('assert');
4+
const repl = require('repl');
5+
const stream = require('stream');
6+
const path = require('path');
77
var buildType = process.config.target_defaults.default_configuration;
88
var buildPath = path.join(__dirname, 'build', buildType, 'binding');
99
// On Windows, escape backslashes in the path before passing it to REPL.

test/debugger/helper-debugger-repl.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22
const common = require('../common');
3-
var assert = require('assert');
4-
var spawn = require('child_process').spawn;
3+
const assert = require('assert');
4+
const spawn = require('child_process').spawn;
55

66
process.env.NODE_DEBUGGER_TIMEOUT = 2000;
77
var port = common.PORT;

test/debugger/test-debugger-repl-break-in-module.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
require('../common');
3-
var repl = require('./helper-debugger-repl.js');
3+
const repl = require('./helper-debugger-repl.js');
44

55
repl.startDebugger('break-in-module/main.js');
66

test/debugger/test-debugger-repl-restart.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
require('../common');
3-
var repl = require('./helper-debugger-repl.js');
3+
const repl = require('./helper-debugger-repl.js');
44

55
repl.startDebugger('breakpoints.js');
66
var linesWithBreakpoint = [

test/debugger/test-debugger-repl-term.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
require('../common');
33
process.env.NODE_FORCE_READLINE = 1;
44

5-
var repl = require('./helper-debugger-repl.js');
5+
const repl = require('./helper-debugger-repl.js');
66

77
repl.startDebugger('breakpoints.js');
88

test/debugger/test-debugger-repl-utf8.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
const common = require('../common');
33
var script = common.fixturesDir + '/breakpoints_utf8.js';
44
process.env.NODE_DEBUGGER_TEST_SCRIPT = script;
55

test/debugger/test-debugger-repl.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
require('../common');
3-
var repl = require('./helper-debugger-repl.js');
3+
const repl = require('./helper-debugger-repl.js');
44

55
repl.startDebugger('breakpoints.js');
66

test/disabled/test-debug-brk-file.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
4-
var spawn = require('child_process').spawn;
5-
var path = require('path');
6-
var net = require('net');
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const spawn = require('child_process').spawn;
5+
const path = require('path');
6+
const net = require('net');
77

88
var isDone = false;
99
var targetPath = path.resolve(common.fixturesDir, 'debug-target.js');

test/disabled/test-dgram-send-error.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
const common = require('../common');
1111
var ITERATIONS = 1000;
1212

13-
var assert = require('assert'),
13+
const assert = require('assert'),
1414
dgram = require('dgram');
1515

1616
var buf = Buffer.alloc(1024, 42);

test/disabled/test-fs-largefile.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
4-
var path = require('path'),
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const path = require('path'),
55
fs = require('fs'),
66
filepath = path.join(common.tmpDir, 'large.txt'),
77
fd = fs.openSync(filepath, 'w+'),

test/disabled/test-http-abort-stream-end.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
2+
const common = require('../common');
3+
const assert = require('assert');
44

5-
var http = require('http');
5+
const http = require('http');
66

77
var maxSize = 1024;
88
var size = 0;

test/disabled/test-https-loop-to-google.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// Tested on node 0.5.0-pre commit 9851574
66

77

8-
var common = require('../common');
9-
var https = require('https');
8+
const common = require('../common');
9+
const https = require('https');
1010

1111
for (var i = 0; i < 10; ++i) {
1212
https.get({

test/disabled/test-readline.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
'use strict';
22
// Can't test this when 'make test' doesn't assign a tty to the stdout.
33
// Yet another use-case for require('tty').spawn ?
4-
var common = require('../common');
5-
var assert = require('assert');
6-
var readline = require('readline');
4+
const common = require('../common');
5+
const assert = require('assert');
6+
const readline = require('readline');
77

88
var key = {
99
xterm: {

test/disabled/test-sendfd.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@
2626
// seen in a response yet. This is intended to ensure that all blobs
2727
// sent out have been relayed back to us.
2828

29-
var common = require('../common');
30-
var assert = require('assert');
29+
const common = require('../common');
30+
const assert = require('assert');
3131

32-
var buffer = require('buffer');
33-
var child_process = require('child_process');
34-
var fs = require('fs');
35-
var net = require('net');
32+
const buffer = require('buffer');
33+
const child_process = require('child_process');
34+
const fs = require('fs');
35+
const net = require('net');
3636
var netBinding = process.binding('net');
37-
var path = require('path');
37+
const path = require('path');
3838

3939
var DATA = {
4040
'ppid' : process.pid,

test/disabled/test-setuidgid.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22
// Requires special privileges
3-
var common = require('../common');
4-
var assert = require('assert');
3+
const common = require('../common');
4+
const assert = require('assert');
55

66
var oldgid = process.getgid();
77
process.setgid('nobody');

test/disabled/tls_server.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
2+
const common = require('../common');
3+
const assert = require('assert');
44

5-
var util = require('util');
6-
var net = require('net');
7-
var fs = require('fs');
8-
var crypto = require('crypto');
5+
const util = require('util');
6+
const net = require('net');
7+
const fs = require('fs');
8+
const crypto = require('crypto');
99

1010
var keyPem = fs.readFileSync(common.fixturesDir + '/cert.pem');
1111
var certPem = fs.readFileSync(common.fixturesDir + '/cert.pem');

test/fixtures/GH-892-request.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
// Called by test/pummel/test-regress-GH-892.js
22

3-
var https = require('https');
4-
var fs = require('fs');
5-
var assert = require('assert');
3+
const https = require('https');
4+
const fs = require('fs');
5+
const assert = require('assert');
66

77
var PORT = parseInt(process.argv[2]);
88
var bytesExpected = parseInt(process.argv[3]);

test/fixtures/a.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var c = require('./b/c');
1+
const c = require('./b/c');
22

33
console.error('load fixtures/a.js');
44

test/fixtures/a1.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var c = require('./b/c');
1+
const c = require('./b/c');
22

33
console.error('load fixtures/a.js');
44

test/fixtures/b/c.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
var d = require('./d');
1+
const d = require('./d');
22

3-
var assert = require('assert');
3+
const assert = require('assert');
44

5-
var package = require('./package');
5+
const package = require('./package');
66

77
assert.equal('world', package.hello);
88

test/fixtures/break-in-module/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var mod = require('./mod.js');
1+
const mod = require('./mod.js');
22
mod.hello();
33
mod.hello();
44
debugger;

test/fixtures/child-process-spawn-node.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var assert = require('assert');
1+
const assert = require('assert');
22

33
function onmessage(m) {
44
console.log('CHILD got message:', m);

test/fixtures/child_process_should_emit_error.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var exec = require('child_process').exec;
1+
const exec = require('child_process').exec;
22

33
[0, 1].forEach(function(i) {
44
exec('ls', function(err, stdout, stderr) {

test/fixtures/cluster-preload-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var cluster = require('cluster');
1+
const cluster = require('cluster');
22
if (cluster.isMaster) {
33
cluster.fork(); // one child
44
cluster.on('exit', function(worker, code, signal) {

test/fixtures/cluster-preload.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
var assert = require('assert');
1+
const assert = require('assert');
22

33
// https://github.com/nodejs/node/issues/1803
44
// this module is used as a preload module. It should have a parent with the
55
// module search paths initialized from the current working directory
66
assert.ok(module.parent);
7-
var expectedPaths = require('module')._nodeModulePaths(process.cwd());
7+
const expectedPaths = require('module')._nodeModulePaths(process.cwd());
88
assert.deepEqual(module.parent.paths, expectedPaths);
99

10-
var cluster = require('cluster');
10+
const cluster = require('cluster');
1111
cluster.isMaster || process.exit(42 + cluster.worker.id); // +42 to distinguish
1212
// from exit(1) for other random reasons

test/fixtures/create-file.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var fs = require('fs');
1+
const fs = require('fs');
22

33
var file_name = process.argv[2];
44
var file_size = parseInt(process.argv[3]);

test/fixtures/cycles/folder/foo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var root = require('./../root');
1+
const root = require('./../root');
22

33
exports.hello = function() {
44
return root.calledFromFoo();

test/fixtures/cycles/root.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var foo = exports.foo = require('./folder/foo');
1+
const foo = exports.foo = require('./folder/foo');
22

33
exports.hello = 'hello';
44
exports.sayHello = function() {

test/fixtures/echo-close-check.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
var common = require('../common');
2-
var assert = require('assert');
3-
var net = require('net');
4-
var fs = require('fs');
1+
const common = require('../common');
2+
const assert = require('assert');
3+
const net = require('net');
4+
const fs = require('fs');
55

66
process.stdout.write('hello world\r\n');
77

test/fixtures/echo.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
var common = require('../common');
2-
var assert = require('assert');
1+
const common = require('../common');
2+
const assert = require('assert');
33

44
process.stdout.write('hello world\r\n');
55

test/fixtures/listen-on-socket-and-exit.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// child process that listens on a socket, allows testing of an EADDRINUSE condition
22

3-
var common = require('../common');
4-
var net = require('net');
3+
const common = require('../common');
4+
const net = require('net');
55

66
common.refreshTmpDir();
77

test/fixtures/module-require/parent/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var child = require('../child');
1+
const child = require('../child');
22
//console.log(child.module.require, child.module);
33
console.log(child.module.require('target'));
44
console.log(child.loaded);

test/fixtures/node_modules/baz/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/node_modules/foo.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/fixtures/not-main-module.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var assert = require('assert');
1+
const assert = require('assert');
22
assert.notEqual(module, require.main, 'require.main should not == module');
33
assert.notEqual(module, process.mainModule,
44
'process.mainModule should not === module');

test/fixtures/parent-process-nonpersistent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
var spawn = require('child_process').spawn,
2+
const spawn = require('child_process').spawn,
33
path = require('path'),
44
childPath = path.join(__dirname, 'child-process-persistent.js');
55

test/fixtures/path-resolve.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
// Tests resolving a path in the context of a spawned process.
22
// See https://github.com/nodejs/node/issues/7215
3-
var path = require('path');
3+
const path = require('path');
44
console.log(path.resolve(process.argv[2]));

test/fixtures/path.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// This is actually more a fixture than a test. It is used to make
2-
var common = require('../common');
2+
const common = require('../common');
33
// sure that require('./path') and require('path') do different things.
44
// It has to be in the same directory as the test 'test-module-loading.js'
55
// and it has to have the same name as an internal module.

test/fixtures/print-chars-from-buffer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var assert = require('assert');
1+
const assert = require('assert');
22

33
var n = parseInt(process.argv[2]);
44

0 commit comments

Comments
 (0)