Skip to content

Commit dcba250

Browse files
targosaddaleax
authored andcommitted
test: refactor and fix test-buffer-bytelength
* assert.equal -> assert.strictEqual. * Fix incorrect use of string instead of RegExp in `throws` assertions. PR-URL: #9808 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent e0e62d1 commit dcba250

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/parallel/test-buffer-bytelength.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ const vm = require('vm');
88

99
// coerce values to string
1010
assert.throws(() => { Buffer.byteLength(32, 'latin1'); },
11-
'"string" must be a string, Buffer, or ArrayBuffer');
11+
/"string" must be a string, Buffer, or ArrayBuffer/);
1212
assert.throws(() => { Buffer.byteLength(NaN, 'utf8'); },
13-
'"string" must be a string, Buffer, or ArrayBuffer');
13+
/"string" must be a string, Buffer, or ArrayBuffer/);
1414
assert.throws(() => { Buffer.byteLength({}, 'latin1'); },
15-
'"string" must be a string, Buffer, or ArrayBuffer');
15+
/"string" must be a string, Buffer, or ArrayBuffer/);
1616
assert.throws(() => { Buffer.byteLength(); },
17-
'"string" must be a string, Buffer, or ArrayBuffer');
17+
/"string" must be a string, Buffer, or ArrayBuffer/);
1818

1919
assert(ArrayBuffer.isView(new Buffer(10)));
2020
assert(ArrayBuffer.isView(new SlowBuffer(10)));
@@ -31,7 +31,7 @@ assert.strictEqual(Buffer.byteLength(ascii), 3);
3131

3232
// ArrayBuffer
3333
var buffer = new ArrayBuffer(8);
34-
assert.equal(Buffer.byteLength(buffer), 8);
34+
assert.strictEqual(Buffer.byteLength(buffer), 8);
3535

3636
// TypedArray
3737
var int8 = new Int8Array(8);

0 commit comments

Comments
 (0)