Skip to content

Commit d566ded

Browse files
sairionbnoordhuis
authored andcommitted
deps: fix V8 debugger bugs
This is following-up fix for https://codereview.chromium.org/813873007/. This bug currently breaks node-inspector client to work. PR-URL: #494 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 6f36630 commit d566ded

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

deps/v8/src/debug-debugger.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1887,7 +1887,7 @@ DebugCommandProcessor.prototype.resolveFrameFromScopeDescription_ =
18871887
// Get the frame for which the scope or scopes are requested.
18881888
// With no frameNumber argument use the currently selected frame.
18891889
if (scope_description && !IS_UNDEFINED(scope_description.frameNumber)) {
1890-
frame_index = scope_description.frameNumber;
1890+
var frame_index = scope_description.frameNumber;
18911891
if (frame_index < 0 || this.exec_state_.frameCount() <= frame_index) {
18921892
throw new Error('Invalid frame number');
18931893
}
@@ -1972,7 +1972,7 @@ DebugCommandProcessor.resolveValue_ = function(value_description) {
19721972
var value_mirror = LookupMirror(value_description.handle);
19731973
if (!value_mirror) {
19741974
throw new Error("Failed to resolve value by handle, ' #" +
1975-
mapping.handle + "# not found");
1975+
value_description.handle + "# not found");
19761976
}
19771977
return value_mirror.value();
19781978
} else if ("stringDescription" in value_description) {
@@ -2127,7 +2127,7 @@ DebugCommandProcessor.prototype.lookupRequest_ = function(request, response) {
21272127

21282128
// Set 'includeSource' option for script lookup.
21292129
if (!IS_UNDEFINED(request.arguments.includeSource)) {
2130-
includeSource = %ToBoolean(request.arguments.includeSource);
2130+
var includeSource = %ToBoolean(request.arguments.includeSource);
21312131
response.setOption('includeSource', includeSource);
21322132
}
21332133

0 commit comments

Comments
 (0)