@@ -401,10 +401,10 @@ seem unfamiliar, refer to this
401
401
All Pull Requests require "sign off" in order to land. Whenever a contributor
402
402
reviews a Pull Request they may find specific details that they would like to
403
403
see changed or fixed. These may be as simple as fixing a typo, or may involve
404
- substantive changes to the code you have written. In general, such requests
405
- are intended to be helpful, but at times may come across as abrupt or unhelpful,
406
- especially requests to change things that do not include concrete suggestions
407
- on * how * to change them.
404
+ substantive changes to the code you have written. While such requests are
405
+ intended to be helpful, they may come across as abrupt or unhelpful, especially
406
+ requests to change things that do not include concrete suggestions on * how * to
407
+ change them.
408
408
409
409
Try not to be discouraged. If you feel that a particular review is unfair,
410
410
say so, or contact one of the other contributors in the project and seek their
@@ -610,8 +610,8 @@ however, will stay intact on the Pull Request page.
610
610
For the size of "one logical change",
611
611
[ 0b5191f] ( https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8 )
612
612
can be a good example. It touches the implementation, the documentation,
613
- and the tests, but is still one logical change. In general, the tests should
614
- always pass when each individual commit lands on the master branch.
613
+ and the tests, but is still one logical change. All tests should always pass
614
+ when each individual commit lands on the master branch.
615
615
616
616
### Getting Approvals for Your Pull Request
617
617
0 commit comments