Skip to content

Commit ce3dcca

Browse files
mykmelezitaloacasas
authored andcommitted
src: update v8_platform.StartInspector signature
The call signature of v8_platform.StartInspector needs to be the same whether or not NODE_USE_V8_PLATFORM, otherwise Node will fail to compile if HAVE_INSPECTOR and !NODE_USE_V8_PLATFORM. (cherry picked from commit e619725) PR-URL: #11157 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 7f9b436 commit ce3dcca

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ static struct {
227227
void PumpMessageLoop(Isolate* isolate) {}
228228
void Dispose() {}
229229
bool StartInspector(Environment *env, const char* script_path,
230-
int port, bool wait) {
230+
const node::DebugOptions& options) {
231231
env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0");
232232
return false; // make compiler happy
233233
}

0 commit comments

Comments
 (0)