Skip to content

Commit c7d8b09

Browse files
phillipjthefourtheye
authored andcommitted
doc: recompile before testing core module changes
Changes to core modules do not take effect unless recompiled. Tip new contributors about this when describing how to run tests in contribution guide. Removed `jslint` from first test command example, as jslint is included when running `make test`. Fixed wrong path of example stream2-transform test. PR-URL: #2051 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent fef87fe commit c7d8b09

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

CONTRIBUTING.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ test/parallel/ directory. Look at other tests to see how they should be
126126
structured (license boilerplate, common includes, etc.).
127127

128128
```text
129-
$ make jslint test
129+
$ ./configure && make -j8 test
130130
```
131131

132132
Make sure the linter is happy and that all tests pass. Please, do not submit
@@ -142,9 +142,11 @@ $ python tools/test.py -v --mode=release parallel/test-stream2-transform
142142
You can run tests directly with iojs:
143143

144144
```text
145-
$ iojs ./test/parallel/test-streams2-transform.js
145+
$ ./iojs ./test/parallel/test-stream2-transform.js
146146
```
147147

148+
Remember to recompile with `make -j8` in between test runs if you change
149+
core modules.
148150

149151
### Step 6: Push
150152

0 commit comments

Comments
 (0)