Skip to content

Commit c723acc

Browse files
committed
Remove some HandleScopes from HTTP
for a %2.5 improvement in hello world HTTP score.
1 parent ce4204a commit c723acc

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

src/node_http.cc

-10
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,6 @@ HTTPConnection::OnEOF ()
129129
int
130130
HTTPConnection::on_message_begin (http_parser *parser)
131131
{
132-
HandleScope scope;
133-
134132
if (message_begin_symbol.IsEmpty()) {
135133
method_symbol = NODE_PSYMBOL("method");
136134
status_code_symbol = NODE_PSYMBOL("statusCode");
@@ -186,7 +184,6 @@ HTTPConnection::on_message_complete (http_parser *parser)
186184
int
187185
HTTPConnection::on_url (http_parser *parser, const char *buf, size_t len)
188186
{
189-
HandleScope scope;
190187
HTTPConnection *connection = static_cast<HTTPConnection*>(parser->data);
191188
assert(connection->refs_);
192189
Local<Value> argv[1] = { String::New(buf, len) };
@@ -197,7 +194,6 @@ HTTPConnection::on_url (http_parser *parser, const char *buf, size_t len)
197194
int
198195
HTTPConnection::on_query_string (http_parser *parser, const char *buf, size_t len)
199196
{
200-
HandleScope scope;
201197
HTTPConnection *connection = static_cast<HTTPConnection*>(parser->data);
202198
assert(connection->refs_);
203199
Local<Value> argv[1] = { String::New(buf, len) };
@@ -208,7 +204,6 @@ HTTPConnection::on_query_string (http_parser *parser, const char *buf, size_t le
208204
int
209205
HTTPConnection::on_path (http_parser *parser, const char *buf, size_t len)
210206
{
211-
HandleScope scope;
212207
HTTPConnection *connection = static_cast<HTTPConnection*>(parser->data);
213208
assert(connection->refs_);
214209
Local<Value> argv[1] = { String::New(buf, len) };
@@ -219,7 +214,6 @@ HTTPConnection::on_path (http_parser *parser, const char *buf, size_t len)
219214
int
220215
HTTPConnection::on_fragment (http_parser *parser, const char *buf, size_t len)
221216
{
222-
HandleScope scope;
223217
HTTPConnection *connection = static_cast<HTTPConnection*>(parser->data);
224218
assert(connection->refs_);
225219
Local<Value> argv[1] = { String::New(buf, len) };
@@ -240,7 +234,6 @@ const static char normalizer[] =
240234
int
241235
HTTPConnection::on_header_field (http_parser *parser, const char *buf, size_t len)
242236
{
243-
HandleScope scope;
244237
HTTPConnection *connection = static_cast<HTTPConnection*>(parser->data);
245238
assert(connection->refs_);
246239

@@ -257,7 +250,6 @@ HTTPConnection::on_header_field (http_parser *parser, const char *buf, size_t le
257250
int
258251
HTTPConnection::on_header_value (http_parser *parser, const char *buf, size_t len)
259252
{
260-
HandleScope scope;
261253
HTTPConnection *connection = static_cast<HTTPConnection*>(parser->data);
262254
assert(connection->refs_);
263255

@@ -293,7 +285,6 @@ HTTPConnection::on_headers_complete (http_parser *parser)
293285
{
294286
HTTPConnection *connection = static_cast<HTTPConnection*> (parser->data);
295287
assert(connection->refs_);
296-
HandleScope scope;
297288

298289
Local<Object> message_info = Object::New();
299290

@@ -339,7 +330,6 @@ HTTPConnection::on_body (http_parser *parser, const char *buf, size_t len)
339330

340331
HTTPConnection *connection = static_cast<HTTPConnection*> (parser->data);
341332
assert(connection->refs_);
342-
HandleScope scope;
343333

344334
// TODO each message should have their encoding.
345335
// don't look at the conneciton for encoding

0 commit comments

Comments
 (0)