Skip to content

Commit bab8b3a

Browse files
targosnodejs-github-bot
authored andcommitted
deps: V8: cherry-pick 8b8703953616
Original commit message: [API] Remove second OnCriticalMemoryPressure Remove the deprecated OnCriticalMemoryPressure method with receives an informative parameter. [email protected] Bug: chromium:634547 Change-Id: I932c3b5030291294dd340362f0b20d374e3067c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780533 Reviewed-by: Michael Lippautz <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/main@{#83254} Refs: v8/v8@8b87039 PR-URL: #44958 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 214354f commit bab8b3a

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.11',
39+
'v8_embedder_string': '-node.12',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-platform.h

-12
Original file line numberDiff line numberDiff line change
@@ -943,18 +943,6 @@ class Platform {
943943
*/
944944
virtual void OnCriticalMemoryPressure() {}
945945

946-
/**
947-
* Enables the embedder to respond in cases where V8 can't allocate large
948-
* memory regions. The |length| parameter is the amount of memory needed.
949-
* Returns true if memory is now available. Returns false if no memory could
950-
* be made available. V8 will retry allocations until this method returns
951-
* false.
952-
*
953-
* Embedder overrides of this function must NOT call back into V8.
954-
*/
955-
V8_DEPRECATED("Use the method without informative parameter")
956-
virtual bool OnCriticalMemoryPressure(size_t length) { return false; }
957-
958946
/**
959947
* Gets the number of worker threads used by
960948
* Call(BlockingTask)OnWorkerThread(). This can be used to estimate the number

0 commit comments

Comments
 (0)