Skip to content

Commit b2587b2

Browse files
committed
http: Avoid EE warning on ECONNREFUSED handling
This is a back-port of the same fix in deb1dc279d49463e13af44feed45c79ae0f379f9, for v0.8.
1 parent 1a95ce5 commit b2587b2

File tree

2 files changed

+59
-2
lines changed

2 files changed

+59
-2
lines changed

lib/http.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -509,9 +509,9 @@ OutgoingMessage.prototype._writeRaw = function(data, encoding) {
509509
// ignored in the first place. We'll probably emit 'close' on the
510510
// next tick, but just in case it's not coming, set a timeout that
511511
// will emit it for us.
512-
if (!this._hangupClose) {
513-
this._hangupClose = true;
512+
if (!this._hangupClose && !this.socket._hangupClose) {
514513
var socket = this.socket;
514+
socket._hangupClose = this._hangupClose = true;
515515
var timer = setTimeout(function() {
516516
socket.emit('close');
517517
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
22+
var common = require('../common');
23+
var assert = require('assert');
24+
25+
// no warnings should happen!
26+
var trace = console.trace;
27+
console.trace = function() {
28+
trace.apply(console, arguments);
29+
throw new Error('no tracing allowed.');
30+
};
31+
32+
var http = require('http');
33+
var net = require('net');
34+
35+
var server = http.createServer(function(req, res) {
36+
res.end('ok');
37+
38+
// Oh no! The connection died!
39+
req.socket.destroy();
40+
});
41+
42+
server.listen(common.PORT);
43+
44+
var client = net.connect({ port: common.PORT, allowHalfOpen: true });
45+
client.on('connect', function() {
46+
for (var i = 0; i < 200; i++) {
47+
client.write('GET / HTTP/1.1\r\n' +
48+
'Host: some.host.name\r\n'+
49+
'\r\n\r\n');
50+
}
51+
client.end();
52+
53+
setTimeout(function() {
54+
server.close();
55+
});
56+
});
57+
client.pipe(process.stdout);

0 commit comments

Comments
 (0)