Skip to content

Commit aeddc36

Browse files
committed
src: remove tracking for exception arrow data
This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway. PR-URL: #17394 Reviewed-By: James M Snell <[email protected]>
1 parent 92011e4 commit aeddc36

File tree

3 files changed

+1
-14
lines changed

3 files changed

+1
-14
lines changed

src/env.h

-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ class ModuleWrap;
9191
V(contextify_global_private_symbol, "node:contextify:global") \
9292
V(decorated_private_symbol, "node:decorated") \
9393
V(npn_buffer_private_symbol, "node:npnBuffer") \
94-
V(processed_private_symbol, "node:processed") \
9594
V(selected_npn_buffer_private_symbol, "node:selectedNpnBuffer") \
9695
V(domain_private_symbol, "node:domain") \
9796

src/node.cc

-10
Original file line numberDiff line numberDiff line change
@@ -1301,16 +1301,6 @@ void AppendExceptionLine(Environment* env,
13011301
Local<Object> err_obj;
13021302
if (!er.IsEmpty() && er->IsObject()) {
13031303
err_obj = er.As<Object>();
1304-
1305-
auto context = env->context();
1306-
auto processed_private_symbol = env->processed_private_symbol();
1307-
// Do it only once per message
1308-
if (err_obj->HasPrivate(context, processed_private_symbol).FromJust())
1309-
return;
1310-
err_obj->SetPrivate(
1311-
context,
1312-
processed_private_symbol,
1313-
True(env->isolate()));
13141304
}
13151305

13161306
// Print (filename):(line number): (message).

src/node_contextify.cc

+1-3
Original file line numberDiff line numberDiff line change
@@ -668,9 +668,7 @@ class ContextifyScript : public BaseObject {
668668
compile_options);
669669

670670
if (v8_script.IsEmpty()) {
671-
if (display_errors) {
672-
DecorateErrorStack(env, try_catch);
673-
}
671+
DecorateErrorStack(env, try_catch);
674672
try_catch.ReThrow();
675673
return;
676674
}

0 commit comments

Comments
 (0)