Skip to content

Commit aec115b

Browse files
committed
meta: update comments for module version
This commit updates the comment for Module Version to document the history of the Module Version number across the various release of Node.js. PR-URL: #16303 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
1 parent 6dcc37d commit aec115b

File tree

1 file changed

+26
-1
lines changed

1 file changed

+26
-1
lines changed

src/node_version.h

+26-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,32 @@
7676
* to load older modules. This should be done whenever
7777
* an API is broken in the C++ side, including in v8 or
7878
* other dependencies.
79+
*
80+
* Node.js will not change the module version during a Major release line
81+
* We will at times update the version of V8 shipped in the release line
82+
* if it can be made ABI compatible with the previous version.
83+
*
84+
* Module version by Node.js version:
85+
* Node.js v0.10.x: 11
86+
* Node.js v0.12.x: 14
87+
* Node.js v4.x: 46
88+
* Node.js v5.x: 47
89+
* Node.js v6.x: 48
90+
* Node.js v7.x: 51
91+
* Node.js v8.x: 57
92+
*
93+
* Module version by V8 ABI version:
94+
* V8 5.4: 51
95+
* V8 5.5: 52
96+
* V8 5.6: 53
97+
* V8 5.7: 54
98+
* V8 5.8: 55
99+
* V8 5.9: 56
100+
* V8 6.0: 57
101+
* V8 6.1: 58
102+
*
103+
* More information can be found at https://nodejs.org/en/download/releases/
79104
*/
80-
#define NODE_MODULE_VERSION 58 /* Node.js v8.0.0 */
105+
#define NODE_MODULE_VERSION 58
81106

82107
#endif // SRC_NODE_VERSION_H_

0 commit comments

Comments
 (0)