Skip to content

Commit 9c2f686

Browse files
gibfahnevanlucas
authored andcommitted
build: don't build deps/zlib if --shared-zlib set
Even if the --shared-zlib flag was used, the bundled deps/zlib was still being compiled into the binary as it was required by the C++ test suite. PR-URL: #10657 Fixes: #10649 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent e3a316f commit 9c2f686

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

node.gyp

+5-1
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,6 @@
900900
'HAVE_INSPECTOR=1',
901901
],
902902
'dependencies': [
903-
'deps/zlib/zlib.gyp:zlib',
904903
'v8_inspector_compress_protocol_json#host'
905904
],
906905
'include_dirs': [
@@ -913,6 +912,11 @@
913912
'test/cctest/test_inspector_socket_server.cc'
914913
],
915914
'conditions': [
915+
[ 'node_shared_zlib=="false"', {
916+
'dependencies': [
917+
'deps/zlib/zlib.gyp:zlib',
918+
]
919+
}],
916920
[ 'node_shared_openssl=="false"', {
917921
'dependencies': [
918922
'deps/openssl/openssl.gyp:openssl'

0 commit comments

Comments
 (0)