Skip to content

Commit 96933df

Browse files
Myles Borinsjasnell
Myles Borins
authored andcommitted
src: update NODE_MODULE_VERSION to 51
When V8 was updated on master to 5.4 there were ABI breaking changes. In the past we have not landed these types of changes before a release, and as such have only bumped the NODE_MODULE_VERSION number in the release commit. Since we are going to be keeping the V8 5.4 beta on master and in the v7 betas I think it makes sense for us to bump the module number prior to a release commit being made. It is possible that this commit should be reverted prior to v7.0.0 being cut. Alternatively we may want to modify our release process for V8 to include a NODE_MODULE_VERSION bump before landing on master when applicable. NODE_MODULE_VERSION is being bumped to 51 instead of 49 to avoid conflicts with NODE_MODULE_VERSIONs being used in electron. Ref: electron/electron#5851 (comment) Ref: #8317 PR-URL: #8808 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent a88bb3a commit 96933df

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,6 @@
4949
* an API is broken in the C++ side, including in v8 or
5050
* other dependencies.
5151
*/
52-
#define NODE_MODULE_VERSION 48 /* Node.js v6.0.0 */
52+
#define NODE_MODULE_VERSION 51 /* Node.js v7.0.0 */
5353

5454
#endif // SRC_NODE_VERSION_H_

0 commit comments

Comments
 (0)