Skip to content

Commit 93660c8

Browse files
committed
node: remove bad fn call and check
These two lines exist because of a screw up on my part while combining MakeCallback() and MakeDomainCallback(). The reason it never broke core tests is because any paths it would have broken were rerouted to AsyncWrap::MakeCallback(). The only case that node::MakeCallback() handles anymore is setImmediate(). Fix: a1da024 "node, async-wrap: remove MakeDomainCallback" PR-URL: #2157 Reviewed-By: Colin Ihrig <[email protected]>
1 parent 99d9d7e commit 93660c8

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/node.cc

-2
Original file line numberDiff line numberDiff line change
@@ -1092,8 +1092,6 @@ Handle<Value> MakeCallback(Environment* env,
10921092
return Undefined(env->isolate());
10931093
}
10941094
}
1095-
env->tick_callback_function()->Call(process, 0, nullptr);
1096-
CHECK_EQ(env->context(), env->isolate()->GetCurrentContext());
10971095

10981096
if (try_catch.HasCaught()) {
10991097
return Undefined(env->isolate());

0 commit comments

Comments
 (0)